From a8a3ff9574806a5591413445b5a94338ceb0d701 Mon Sep 17 00:00:00 2001
From: Allan Sandfeld Jensen <allan.jensen@qt.io>
Date: Thu, 14 Feb 2019 15:48:15 +0100
Subject: Fix crash on removing certificates from local store
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

I shouldn't cache end when operating on a changing list.

Change-Id: I09a69e238675600fde7a7d9bc75dffe1fb22c4eb
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
---
 src/core/api/qwebengineclientcertificatestore.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'src')

diff --git a/src/core/api/qwebengineclientcertificatestore.cpp b/src/core/api/qwebengineclientcertificatestore.cpp
index 471b31326..850dd16d7 100644
--- a/src/core/api/qwebengineclientcertificatestore.cpp
+++ b/src/core/api/qwebengineclientcertificatestore.cpp
@@ -129,8 +129,7 @@ QList<QWebEngineClientCertificateStore::Entry> QWebEngineClientCertificateStore:
 void QWebEngineClientCertificateStore::remove(Entry entry)
 {
     auto it = d_ptr->addedCerts.begin();
-    const auto end = d_ptr->addedCerts.end();
-    while (it != end) {
+    while (it != d_ptr->addedCerts.end()) {
         auto *overrideData = *it;
         if (entry.certificate.toDer() == overrideData->certificate.toDer()) {
             d_ptr->deletedCerts.append(overrideData);
-- 
cgit v1.2.3