From 742e6786aeb500ef9bc850bf84803d5f388e3927 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Wed, 6 Apr 2022 12:27:17 +0200 Subject: Fix navigation to non-local URLs They are passed in another part of the DropItem object. Task-number: QTBUG-102192 Pick-to: 6.3 6.2 5.15 Change-Id: If52a88ce2688c25ea0edcc0d1e8f962f2cdd29dd Reviewed-by: Kirill Burtsev --- tests/auto/widgets/qwebengineview/BLACKLIST | 2 +- tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) (limited to 'tests/auto/widgets') diff --git a/tests/auto/widgets/qwebengineview/BLACKLIST b/tests/auto/widgets/qwebengineview/BLACKLIST index 99161a591..4bc678d10 100644 --- a/tests/auto/widgets/qwebengineview/BLACKLIST +++ b/tests/auto/widgets/qwebengineview/BLACKLIST @@ -13,5 +13,5 @@ osx [reusePage] b2qt arm -[navigateOnDrop] +[navigateOnDrop:file] windows diff --git a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp index 14666e3c0..1d8fa42bf 100644 --- a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp +++ b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp @@ -176,6 +176,7 @@ private Q_SLOTS: void closeDiscardsPage(); void loadAfterRendererCrashed(); void inspectElement(); + void navigateOnDrop_data(); void navigateOnDrop(); }; @@ -3519,8 +3520,16 @@ void tst_QWebEngineView::inspectElement() QTest::qWait(100); } +void tst_QWebEngineView::navigateOnDrop_data() +{ + QTest::addColumn("url"); + QTest::newRow("file") << QUrl::fromLocalFile(QDir(QT_TESTCASE_SOURCEDIR).absoluteFilePath("resources/dummy.html")); + QTest::newRow("qrc") << QUrl("qrc:///resources/dummy.html"); +} + void tst_QWebEngineView::navigateOnDrop() { + QFETCH(QUrl, url); struct WebEngineView : QWebEngineView { QWebEngineView* createWindow(QWebEnginePage::WebWindowType /* type */) override { return this; } } view; @@ -3529,7 +3538,6 @@ void tst_QWebEngineView::navigateOnDrop() QVERIFY(QTest::qWaitForWindowExposed(&view)); QSignalSpy loadSpy(&view, &QWebEngineView::loadFinished); - auto url = QUrl::fromLocalFile(QDir(QT_TESTCASE_SOURCEDIR).absoluteFilePath("resources/dummy.html")); QMimeData mimeData; mimeData.setUrls({ url }); -- cgit v1.2.3