From 75aa1821d151f2103abece4942624104426e0c17 Mon Sep 17 00:00:00 2001 From: Jocelyn Turcotte Date: Fri, 21 Mar 2014 17:34:21 +0100 Subject: Fix a missing titleChanged signal on navigation WebContentsView::SetPageTitle is only called when the Blink page updated its title. For navigations we have to listen for NavigationStateChanged. Also update the history test to check this case. Change-Id: Ia89c61b32913d647a63b2fb9a4cdf3f6867c4f0c Reviewed-by: Pierre Rossi --- tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tests/auto/widgets') diff --git a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp index 2b5f4101c..f2b11c5c2 100644 --- a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp +++ b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp @@ -124,10 +124,13 @@ void tst_QWebEngineHistory::count() */ void tst_QWebEngineHistory::back() { + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); + for (int i = histsize;i > 1;i--) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->back(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->back(); @@ -145,10 +148,12 @@ void tst_QWebEngineHistory::forward() loadFinishedBarrier->ensureSignalEmitted(); } + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); for (int i = 1;i < histsize;i++) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->forward(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->forward(); -- cgit v1.2.3