From 58b0b8d52222018c814b5e1c0d0d8cf648bca835 Mon Sep 17 00:00:00 2001 From: Peter Varga Date: Mon, 5 Mar 2018 13:45:23 +0100 Subject: Stabilize WebEngineViewLoadHtml::test_loadProgressAfterLoadHtml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous test will set the webEngineView.loadProgress to 100 due to a successful load. Therefore, the test can't expect 0 loadProgress at the beginning. Count the loadProgress changes instead of checking the initial value. Change-Id: I8f4727d5b8c7ebf1b7c640e44a9eb3ca5a7fef44 Reviewed-by: Jüri Valdmann Reviewed-by: Allan Sandfeld Jensen --- tests/auto/quick/qmltests/data/tst_loadHtml.qml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'tests/auto') diff --git a/tests/auto/quick/qmltests/data/tst_loadHtml.qml b/tests/auto/quick/qmltests/data/tst_loadHtml.qml index 73b6139e2..ed1de41fd 100644 --- a/tests/auto/quick/qmltests/data/tst_loadHtml.qml +++ b/tests/auto/quick/qmltests/data/tst_loadHtml.qml @@ -46,10 +46,18 @@ TestWebEngineView { when: windowShown function test_loadProgressAfterLoadHtml() { - compare(webEngineView.loadProgress, 0) + var loadProgressChangedCount = 0; + + var handleLoadProgressChanged = function() { + loadProgressChangedCount++; + } + + webEngineView.loadProgressChanged.connect(handleLoadProgressChanged); webEngineView.loadHtml("Test page 1Hello.") verify(webEngineView.waitForLoadSucceeded()) compare(webEngineView.loadProgress, 100) + verify(loadProgressChangedCount); + webEngineView.loadProgressChanged.disconnect(handleLoadProgressChanged); } function test_dataURLFragment() { -- cgit v1.2.3