From 1e11575a32685f7ac01f8b0cd425fa8d3ce3de33 Mon Sep 17 00:00:00 2001 From: Allan Sandfeld Jensen Date: Wed, 22 Aug 2018 16:12:38 +0200 Subject: Avoid reattach of page before deleting it Also fixes potential double delete if you do delete a view's implied page. Change-Id: Ib74128c0801f992694f4a5d8c148974039a6c7b2 Reviewed-by: Michal Klocek Reviewed-by: Zakor Tamas --- tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'tests') diff --git a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp index 5f30fa6b9..1499a5f05 100644 --- a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp +++ b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp @@ -188,6 +188,7 @@ private Q_SLOTS: void webUIURLs(); void visibilityState(); void jsKeyboardEvent(); + void deletePage(); }; // This will be called before the first test function is executed. @@ -2793,5 +2794,19 @@ void tst_QWebEngineView::jsKeyboardEvent() QCOMPARE(evaluateJavaScriptSync(view.page(), "log"), expected); } +void tst_QWebEngineView::deletePage() +{ + QWebEngineView view; + QWebEnginePage *page = view.page(); + QVERIFY(page); + QCOMPARE(page->parent(), &view); + delete page; + // Test that a new page is created and that it is useful: + QVERIFY(view.page()); + QSignalSpy spy(view.page(), &QWebEnginePage::loadFinished); + view.page()->load(QStringLiteral("about:blank")); + QTRY_VERIFY(spy.count()); +} + QTEST_MAIN(tst_QWebEngineView) #include "tst_qwebengineview.moc" -- cgit v1.2.3