From 9da1716d05770f6deb3af654f28024234d711eb7 Mon Sep 17 00:00:00 2001 From: Adam Kallai Date: Wed, 25 May 2016 11:29:57 +0200 Subject: Unskip test_errorPageEnabled in tst_favicon.qml test - Unskip this test becuse the releted issue is already fixed. - It is worth to restore the initial page before each test functions, not only when there was icon url. Change-Id: I2a71e026ab3ffabb8de191b7296a67ac44479934 Reviewed-by: Allan Sandfeld Jensen --- tests/auto/quick/qmltests/data/tst_favicon.qml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'tests') diff --git a/tests/auto/quick/qmltests/data/tst_favicon.qml b/tests/auto/quick/qmltests/data/tst_favicon.qml index 633859add..f8ad998ef 100644 --- a/tests/auto/quick/qmltests/data/tst_favicon.qml +++ b/tests/auto/quick/qmltests/data/tst_favicon.qml @@ -70,14 +70,11 @@ TestWebEngineView { name: "WebEngineFavicon" when: windowShown - function init() { - if (webEngineView.icon != '') { - // If this is not the first test, then load a blank page without favicon, restoring the initial state. - webEngineView.url = 'about:blank' - verify(webEngineView.waitForLoadSucceeded()) - iconChangedSpy.wait() - } + function init() { + // It is worth to restore the initial state with loading a blank page before all test functions. + webEngineView.url = 'about:blank' + verify(webEngineView.waitForLoadSucceeded()) iconChangedSpy.clear() } @@ -149,7 +146,6 @@ TestWebEngineView { } function test_errorPageEnabled() { - skip("Error page does not work properly: QTBUG-48995") WebEngine.settings.errorPageEnabled = true compare(iconChangedSpy.count, 0) -- cgit v1.2.3