From ef30fe45786d5f2e0b2a5023510e49f2a8d72ab7 Mon Sep 17 00:00:00 2001 From: Balazs Egedi Date: Wed, 9 Jun 2021 14:38:20 +0200 Subject: FIXUP: Fix QWebEngineDownloadRequest signals - Included the test for Quick Controls 2 in CMake. - Fixed warning about deprecated injection of parameters into signal handlers. Change-Id: I8f517e84cb6b0c67e3f12bc3d047f0b61096d5fe Reviewed-by: Michal Klocek (cherry picked from commit c3108a1a7ab64a3fff2c2b7284ac22020571e2b7) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/quick/qmltests/CMakeLists.txt | 2 +- tests/auto/quick/qmltests/data/tst_download.qml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/auto/quick/qmltests/CMakeLists.txt b/tests/auto/quick/qmltests/CMakeLists.txt index 55d4c74f5..487d07dc8 100644 --- a/tests/auto/quick/qmltests/CMakeLists.txt +++ b/tests/auto/quick/qmltests/CMakeLists.txt @@ -16,6 +16,7 @@ set(testList tst_activeFocusOnPress.qml tst_audioMuted.qml tst_desktopBehaviorLoadHtml.qml + tst_download.qml tst_favicon.qml tst_filePicker.qml tst_findText.qml @@ -67,7 +68,6 @@ endif() if(TARGET Qt::QuickControls) #FIXME list(APPEND testList tst_contextMenu.qml - tst_download.qml ) else() message("\n!!!! QuickControls target is missing, some tests are not executed !!! FIXME \n") diff --git a/tests/auto/quick/qmltests/data/tst_download.qml b/tests/auto/quick/qmltests/data/tst_download.qml index a26060046..bac4d5cc5 100644 --- a/tests/auto/quick/qmltests/data/tst_download.qml +++ b/tests/auto/quick/qmltests/data/tst_download.qml @@ -96,7 +96,7 @@ TestWebEngineView { WebEngineProfile { id: testDownloadProfile - onDownloadRequested: { + onDownloadRequested: function(download) { testDownloadProfile.downloadPath = tempDir.path() downloadState.push(download.state) downloadItemConnections.target = download @@ -126,7 +126,7 @@ TestWebEngineView { downloadUrl = download.url suggestedFileName = download.suggestedFileName } - onDownloadFinished: { + onDownloadFinished: function(download) { receivedBytes = download.receivedBytes; } } -- cgit v1.2.3