diff options
| author | Joerg Bornemann <joerg.bornemann@qt.io> | 2021-07-06 18:24:11 +0200 |
|---|---|---|
| committer | Joerg Bornemann <joerg.bornemann@qt.io> | 2021-07-06 21:06:05 +0200 |
| commit | caa85ce2f1bb90c98d2096231b8f6eedf978c64a (patch) | |
| tree | b62344335fdc267e14e826d36cc93110e4b4c751 /src | |
| parent | 2d9fe6a2a93e8b15abe8d20d53c07a5c5b9bbaca (diff) | |
CMake: Don't give plugins PUBLIC usage requirements
The pro2cmake.py conversion script faithfully reproduced the .pro files
for the plugins, which specified the libraries as public. But in CMake,
the implications of this are that public usage requirements should then
be propagated to consumers. We don't expect any consumers, since a
plugin is created as a MODULE library in CMake, so for Windows we don't
even have an import library to link with. The only exception to this is
for static builds where plugins are created as STATIC libraries
instead, but only in certain controlled situations do we then link to
plugins. Even then, usage requirements are not expected to propagate to
the consumers, so these relationships should always be specified as
private.
Pick-to: 6.2
Task-number: QTBUG-90819
Change-Id: I8a7cc92826709267cc44b210c64fb3940ea20eee
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'src')
| -rw-r--r-- | src/imports/qmlwebsockets/CMakeLists.txt | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/imports/qmlwebsockets/CMakeLists.txt b/src/imports/qmlwebsockets/CMakeLists.txt index 06316bf..33daae8 100644 --- a/src/imports/qmlwebsockets/CMakeLists.txt +++ b/src/imports/qmlwebsockets/CMakeLists.txt @@ -12,9 +12,8 @@ qt_internal_add_qml_module(qmlwebsockets qmlwebsockets_plugin.cpp qmlwebsockets_plugin.h qqmlwebsocket.cpp qqmlwebsocket.h qqmlwebsocketserver.cpp qqmlwebsocketserver.h - PUBLIC_LIBRARIES + LIBRARIES Qt::CorePrivate Qt::QmlPrivate Qt::WebSockets ) - |