summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Erb <erb@suitabletech.com>2018-03-23 16:04:14 -0400
committerJason Erb (Suitable Technologies) <erb@suitabletech.com>2018-04-05 01:48:40 +0000
commitbb7dda99936b97cc262f07b25fcb500f8a552c8a (patch)
tree9c38eb0ae0cabd9a8520731a1dce3eb5c94609d4
parent574bb84a8b17b510b2ad8661a3bc5fa54e021310 (diff)
Darwin: open links with target="_blank" externallyv5.11.0-beta4
Without this change, such links do not open at all. Task-number: QTBUG-67293 Change-Id: I15e7944dc75271948c6356ac9f949333039b9671 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> Reviewed-by: Andy Shaw <andy.shaw@qt.io>
-rw-r--r--src/plugins/darwin/qdarwinwebview.mm4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/plugins/darwin/qdarwinwebview.mm b/src/plugins/darwin/qdarwinwebview.mm
index c8cb11f..66bb61f 100644
--- a/src/plugins/darwin/qdarwinwebview.mm
+++ b/src/plugins/darwin/qdarwinwebview.mm
@@ -213,6 +213,10 @@ decidePolicyForNavigationAction:(WKNavigationAction *)navigationAction
Q_UNUSED(webView);
NSURL *url = navigationAction.request.URL;
const BOOL handled = (^{
+ // For links with target="_blank", open externally
+ if (!navigationAction.targetFrame)
+ return NO;
+
#if QT_MACOS_IOS_PLATFORM_SDK_EQUAL_OR_ABOVE(101300, 110000)
if (__builtin_available(macOS 10.13, iOS 11.0, *)) {
return [WKWebView handlesURLScheme:url.scheme];