aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2016-12-21 16:17:01 +0100
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2016-12-22 07:59:50 +0000
commit210b31fa48134ace767be47508b9918bcee9a22d (patch)
tree2280b26862d1e825c0be9d4f4a10f16521ca8ea0
parent1627b577b593ebc636db16da298b26ca5d8d8d6d (diff)
Remove foreach from tests and examples
Replace by range based for loops. Amends change 13604e3fcc12a536d228f415ce65ca1c86b7015b. Change-Id: Ie0712c6fd1743bc7ca8345de58b49a08e1f69653 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io>
-rw-r--r--examples/winextras/musicplayer/main.cpp6
-rw-r--r--src/imports/winextras/qquickjumplist.cpp5
2 files changed, 7 insertions, 4 deletions
diff --git a/examples/winextras/musicplayer/main.cpp b/examples/winextras/musicplayer/main.cpp
index 0502015..6a74bca 100644
--- a/examples/winextras/musicplayer/main.cpp
+++ b/examples/winextras/musicplayer/main.cpp
@@ -68,8 +68,10 @@ static bool associateFileTypes()
settings.beginGroup(QStringLiteral("SupportedTypes"));
QMimeDatabase mimeDatabase;
- foreach (const QString &fileType, MusicPlayer::supportedMimeTypes()) {
- foreach (QString suffix, mimeDatabase.mimeTypeForName(fileType).suffixes()) {
+ const QStringList supportedMimeTypes = MusicPlayer::supportedMimeTypes();
+ for (const QString &fileType : supportedMimeTypes) {
+ const QStringList suffixes = mimeDatabase.mimeTypeForName(fileType).suffixes();
+ for (QString suffix : suffixes) {
suffix.prepend('.');
settings.setValue(suffix, QString());
}
diff --git a/src/imports/winextras/qquickjumplist.cpp b/src/imports/winextras/qquickjumplist.cpp
index a60de40..2126e0c 100644
--- a/src/imports/winextras/qquickjumplist.cpp
+++ b/src/imports/winextras/qquickjumplist.cpp
@@ -170,10 +170,11 @@ void QQuickJumpList::rebuild()
jumpList.frequent()->setVisible(m_frequent && m_frequent->isVisible());
if (m_tasks && m_tasks->isVisible()) {
jumpList.tasks()->setVisible(true);
- foreach (QWinJumpListItem *item, m_tasks->toItemList())
+ const QList<QWinJumpListItem *> &itemList = m_tasks->toItemList();
+ for (QWinJumpListItem *item : itemList)
jumpList.tasks()->addItem(item);
}
- foreach (QQuickJumpListCategory *category, m_categories) {
+ for (QQuickJumpListCategory *category : qAsConst(m_categories)) {
if (category->isVisible())
jumpList.addCategory(category->title(), category->toItemList())->setVisible(true);
}