QWinJumpListCategory: ignore and warn about unsupported item types

Change-Id: I119fba0938c3cb3caab7545ced18106051b531ac
Reviewed-by: Ivan Vizir <define-true-false@yandex.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>

1 files changed, 11 insertions, 5 deletions

diff --git a/src/winextras/qwinjumplistcategory.cpp b/src/winextras/qwinjumplistcategory.cpp
index bab65ca..c338bf6 100644
--- a/src/winextras/qwinjumplistcategory.cpp
+++ b/src/winextras/qwinjumplistcategory.cpp
@@ -239,6 +239,17 @@ void QWinJumpListCategory::addItem(QWinJumpListItem *item)
     if (!item)
         return;
 
+    if (d->type == Recent || d->type == Frequent) {
+        if (item->type() == QWinJumpListItem::Separator) {
+            qWarning("QWinJumpListCategory::addItem(): only tasks/custom categories support separators.");
+            return;
+        }
+        if (item->type() == QWinJumpListItem::Destination) {
+            qWarning("QWinJumpListCategory::addItem(): only tasks/custom categories support destinations.");
+            return;
+        }
+    }
+
     QWinJumpListItemPrivate *p = QWinJumpListItemPrivate::get(item);
     if (p->category != this) {
         p->category = this;
@@ -293,11 +304,6 @@ QWinJumpListItem *QWinJumpListCategory::addLink(const QIcon &icon, const QString
  */
 QWinJumpListItem *QWinJumpListCategory::addSeparator()
 {
-    Q_D(QWinJumpListCategory);
-    if (d->type != Tasks) {
-        qWarning("QWinJumpListCategory::addSeparator(): only tasks category supports separators.");
-        return 0;
-    }
     QWinJumpListItem *item = new QWinJumpListItem(QWinJumpListItem::Separator);
     addItem(item);
     return item;