From 02f4919c7fc11ad5c60e89404542c6a95a10d3e9 Mon Sep 17 00:00:00 2001
From: Sona Kurazyan <sona.kurazyan@qt.io>
Date: Mon, 2 May 2022 10:58:48 +0200
Subject: Avoid extra copy in a ranged loop
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This avoids:

 warning: loop variable ‘node’ creates a copy from type
 ‘const QPatternist::TargetNode’ [-Wrange-loop-construct]

Task-number: QTBUG-102867
Change-Id: I46df9f502782991fe74b5260f86bead829c67cf6
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
---
 src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
index 22e6dd9b..c7abbfe5 100644
--- a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
+++ b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
@@ -998,7 +998,7 @@ bool XsdValidatingInstanceReader::validateKeyIdentityConstraint(const XsdElement
         return false;
 
     // 4.2.3
-    for (const TargetNode node : qualifiedNodeSet) {
+    for (const TargetNode &node : qualifiedNodeSet) {
         const QVector<QXmlItem> fieldItems = node.fieldItems();
         for (int i = 0; i < fieldItems.count(); ++i) {
             const QXmlNodeModelIndex index = fieldItems.at(i).toNodeModelIndex();
-- 
cgit v1.2.3