From 0cce5a54b0f9971021fc0bd0c11198fbe7845ee8 Mon Sep 17 00:00:00 2001
From: Andy Nichols <andy.nichols@qt.io>
Date: Tue, 27 Aug 2019 09:30:11 +0200
Subject: Disable Depth Pre-pass by default
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is an anti-optimization on tiled renderers and doesn't provide much
performance benefit on even desktop hardware.

This patch makes the depth pre-pass opt-in instead of opt-out.

Change-Id: I73cdc0aac5e5c07977085eefd1fad7ba890d0fdb
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
---
 res/DataModelMetadata/en-us/MetaData.xml        | 2 +-
 src/dm/systems/Qt3DSDMComposerTypeDefinitions.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/res/DataModelMetadata/en-us/MetaData.xml b/res/DataModelMetadata/en-us/MetaData.xml
index 951a2fb..30db5b3 100644
--- a/res/DataModelMetadata/en-us/MetaData.xml
+++ b/res/DataModelMetadata/en-us/MetaData.xml
@@ -347,7 +347,7 @@
 
         <!-- Advanced -->
         <Property name="disabledepthtest"    formalName="Disable Depth Test"    type="Boolean" animatable="False" category="Advanced" description="Optimize render speed for layers with\nmostly transparent objects?" />
-        <Property name="disabledepthprepass" formalName="Disable Depth Prepass" type="Boolean" animatable="False" category="Advanced" description="Optimize render speed for layers\nwith low depth complexity" />
+        <Property name="disabledepthprepass" formalName="Disable Depth Prepass" type="Boolean" animatable="False" default="True" category="Advanced" description="Optimize render speed for layers\nwith low depth complexity" />
 
         <!-- Hidden props -->
         <Property name="position"     formalName="Position"               type="Vector"                        category="Basic Properties" hidden="True" description="Location in local space" />
diff --git a/src/dm/systems/Qt3DSDMComposerTypeDefinitions.h b/src/dm/systems/Qt3DSDMComposerTypeDefinitions.h
index 1a07940..9a075ae 100644
--- a/src/dm/systems/Qt3DSDMComposerTypeDefinitions.h
+++ b/src/dm/systems/Qt3DSDMComposerTypeDefinitions.h
@@ -200,7 +200,7 @@ class IPropertySystem;
     HANDLE_COMPOSER_PROPERTY(multisampleaa, m_MultisampleAA, TDataStrPtr, L"None")                 \
     HANDLE_COMPOSER_PROPERTY(temporalaa, m_TemporalAA, bool, false)                                \
     HANDLE_COMPOSER_PROPERTY(disabledepthtest, m_DisableDepthTest, bool, false)                    \
-    HANDLE_COMPOSER_PROPERTY(disabledepthprepass, m_DisableDepthPrepass, bool, false)              \
+    HANDLE_COMPOSER_PROPERTY(disabledepthprepass, m_DisableDepthPrepass, bool, true)              \
     HANDLE_COMPOSER_PROPERTY(background, m_Background, TDataStrPtr, L"Transparent")                \
     HANDLE_COMPOSER_PROPERTY_DUPLICATE(backgroundcolor, m_BackgroundColor, SFloat4,                \
                                        SFloat4(0, 0, 0, 1))                                        \
-- 
cgit v1.2.3