From 30790560a7f4f30b3bdcc21499d5a1d584bab0a9 Mon Sep 17 00:00:00 2001
From: Tony Leinonen <tony.leinonen@qt.io>
Date: Mon, 7 Sep 2020 10:13:02 +0300
Subject: Set zero initialization for vector
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

data was uninitialized which wrote random bytes to rotations
position on gcc compiler

Task-number: QT3DS-4118
Change-Id: I2d5a4a053e1a3ab4a41f3c181f2a4440416a57ed
Reviewed-by: Tomi Korpipää <tomi.korpipaa@qt.io>
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
Reviewed-by: Kaj Grönholm <kaj.gronholm@qt.io>
---
 src/Authoring/Qt3DStudio/Render/StudioTranslationWidget.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'src/Authoring')

diff --git a/src/Authoring/Qt3DStudio/Render/StudioTranslationWidget.cpp b/src/Authoring/Qt3DStudio/Render/StudioTranslationWidget.cpp
index 47206714..cb2a117d 100644
--- a/src/Authoring/Qt3DStudio/Render/StudioTranslationWidget.cpp
+++ b/src/Authoring/Qt3DStudio/Render/StudioTranslationWidget.cpp
@@ -135,7 +135,6 @@ struct STranslationWidget : public SStudioWidgetImpl<StudioWidgetTypes::Translat
             theTempCamera.m_Position.x = 0;
             theTempCamera.m_Position.y = 0;
             theTempCamera.m_ClipFar = 2.0f * theCameraSetback;
-
             // Use entire viewport
             theTempCamera.CalculateGlobalVariables(
                         viewport,
@@ -148,7 +147,7 @@ struct STranslationWidget : public SStudioWidgetImpl<StudioWidgetTypes::Translat
             auto rot = QT3DSMat44::createIdentity();
             if (helpWidgetInfo.m_Camera->m_Flags.IsOrthographic()) {
                 rot = helpWidgetInfo.m_Camera->m_LocalTransform;
-                rot.setPosition({});
+                rot.setPosition({0, 0, 0});
                 rot = rot.getInverse().getTranspose();
             } else {
                 helpWidgetInfo.m_Camera->CalculateRotationMatrix(rot);
-- 
cgit v1.2.3