diff options
author | Dariusz Luksza <dluksza@collab.net> | 2016-07-05 10:57:26 +0200 |
---|---|---|
committer | David Pursehouse <dpursehouse@collab.net> | 2019-07-17 20:16:38 +0900 |
commit | 6bd4959ad5b0dab5409d446e91561802ac163f68 (patch) | |
tree | 2aac3820edc53720c1f3e3bf4b5a33b06be626db | |
parent | 624ec820682e0d7b163e1de262134b7b94087441 (diff) |
Make more classes and fields public to ease extensibility
Make classes public, and their constructors protected, to allow
them to be extended.
Make event type names and fields public.
Change-Id: Iba275f99b7afbf87d57dd44851d043ad0f23fbe1
6 files changed, 19 insertions, 19 deletions
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/DestinationConfiguration.java b/src/main/java/com/googlesource/gerrit/plugins/replication/DestinationConfiguration.java index 856ffb1..b2d0de2 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/DestinationConfiguration.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/DestinationConfiguration.java @@ -19,7 +19,7 @@ import com.google.common.collect.ImmutableList; import org.eclipse.jgit.lib.Config; import org.eclipse.jgit.transport.RemoteConfig; -class DestinationConfiguration { +public class DestinationConfiguration { static final int DEFAULT_REPLICATION_DELAY = 15; static final int DEFAULT_RESCHEDULE_DELAY = 3; @@ -40,7 +40,7 @@ class DestinationConfiguration { private final RemoteConfig remoteConfig; private final int maxRetries; - DestinationConfiguration(RemoteConfig remoteConfig, Config cfg) { + protected DestinationConfiguration(RemoteConfig remoteConfig, Config cfg) { this.remoteConfig = remoteConfig; String name = remoteConfig.getName(); urls = ImmutableList.copyOf(cfg.getStringList("remote", name, "url")); diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicatedEvent.java b/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicatedEvent.java index 364f1b4..fccdb7b 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicatedEvent.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicatedEvent.java @@ -21,13 +21,13 @@ import org.eclipse.jgit.transport.RemoteRefUpdate; import org.eclipse.jgit.transport.RemoteRefUpdate.Status; public class RefReplicatedEvent extends RefEvent { - static final String TYPE = "ref-replicated"; + public static final String TYPE = "ref-replicated"; - final String project; - final String ref; - final String targetNode; - final String status; - final Status refStatus; + public final String project; + public final String ref; + public final String targetNode; + public final String status; + public final Status refStatus; public RefReplicatedEvent( String project, diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicationDoneEvent.java b/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicationDoneEvent.java index 90595b3..4789a96 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicationDoneEvent.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/RefReplicationDoneEvent.java @@ -18,7 +18,7 @@ import com.google.gerrit.reviewdb.client.Project; import com.google.gerrit.server.events.RefEvent; public class RefReplicationDoneEvent extends RefEvent { - static final String TYPE = "ref-replication-done"; + public static final String TYPE = "ref-replication-done"; final String project; final String ref; diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationScheduledEvent.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationScheduledEvent.java index 7268709..cd7a3cf 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationScheduledEvent.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationScheduledEvent.java @@ -19,11 +19,11 @@ import com.google.gerrit.reviewdb.client.Project.NameKey; import com.google.gerrit.server.events.RefEvent; public class ReplicationScheduledEvent extends RefEvent { - static final String TYPE = "ref-replication-scheduled"; + public static final String TYPE = "ref-replication-scheduled"; - final String project; - final String ref; - final String targetNode; + public final String project; + public final String ref; + public final String targetNode; public ReplicationScheduledEvent(String project, String ref, String targetNode) { super(TYPE); diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationStateLogger.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationStateLogger.java index cfa95dd..f2d55de 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationStateLogger.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationStateLogger.java @@ -26,7 +26,7 @@ import com.google.inject.Singleton; * state to the stderr console. */ @Singleton -class ReplicationStateLogger implements ReplicationStateListener { +public class ReplicationStateLogger implements ReplicationStateListener { @Override public void warn(String msg, ReplicationState... states) { diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java b/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java index 46f6ac0..2b16a66 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java @@ -25,20 +25,20 @@ import org.eclipse.jgit.transport.URIish; import org.eclipse.jgit.util.FS; import org.eclipse.jgit.util.io.StreamCopyThread; -class SshHelper { +public class SshHelper { private final Provider<SshSessionFactory> sshSessionFactoryProvider; private final int commandTimeout; private final int connectionTimeout; @Inject - SshHelper( + protected SshHelper( ReplicationConfig replicationConfig, Provider<SshSessionFactory> sshSessionFactoryProvider) { this.sshSessionFactoryProvider = sshSessionFactoryProvider; this.commandTimeout = replicationConfig.getSshCommandTimeout(); this.connectionTimeout = replicationConfig.getSshConnectionTimeout(); } - int executeRemoteSsh(URIish uri, String cmd, OutputStream errStream) throws IOException { + public int executeRemoteSsh(URIish uri, String cmd, OutputStream errStream) throws IOException { RemoteSession ssh = connect(uri); Process proc = ssh.exec(cmd, commandTimeout); proc.getOutputStream().close(); @@ -57,7 +57,7 @@ class SshHelper { return proc.exitValue(); } - OutputStream newErrorBufferStream() { + public OutputStream newErrorBufferStream() { return new OutputStream() { private final StringBuilder out = new StringBuilder(); private final StringBuilder line = new StringBuilder(); @@ -86,7 +86,7 @@ class SshHelper { }; } - RemoteSession connect(URIish uri) throws TransportException { + protected RemoteSession connect(URIish uri) throws TransportException { return sshSessionFactoryProvider.get().getSession(uri, null, FS.DETECTED, connectionTimeout); } } |