summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHan-Wen Nienhuys <hanwen@google.com>2017-06-13 18:15:38 +0200
committerHan-Wen Nienhuys <hanwen@google.com>2017-06-13 18:15:38 +0200
commitf9e2ef3f01d8b4a0e4951ff7195d2989f75a20dc (patch)
tree195bb4dd0bfc81c94826c53a3a90583e3cc17b02
parent3afb87fff2cf5034d757ae491b9a85af645eb638 (diff)
Remove 'final' from function signatures
-rw-r--r--src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java4
-rw-r--r--src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java8
-rw-r--r--src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java4
-rw-r--r--src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java2
-rw-r--r--src/main/java/com/googlesource/gerrit/plugins/replication/StartCommand.java4
5 files changed, 11 insertions, 11 deletions
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
index bc2bb22..0c4bd77 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java
@@ -239,7 +239,7 @@ public class Destination {
}
private boolean shouldReplicate(
- final Project.NameKey project, final String ref, ReplicationState... states) {
+ final Project.NameKey project, String ref, ReplicationState... states) {
try {
return threadScoper
.scope(
@@ -262,7 +262,7 @@ public class Destination {
return false;
}
- private boolean shouldReplicate(final Project.NameKey project, ReplicationState... states) {
+ private boolean shouldReplicate(Project.NameKey project, ReplicationState... states) {
try {
return threadScoper
.scope(
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java b/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
index 0c3e158..951ae9c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/PushResultProcessing.java
@@ -43,7 +43,7 @@ public abstract class PushResultProcessing {
*
* @param message message text.
*/
- void writeStdOut(final String message) {
+ void writeStdOut(String message) {
// Default doing nothing
}
@@ -52,7 +52,7 @@ public abstract class PushResultProcessing {
*
* @param message message text.
*/
- void writeStdErr(final String message) {
+ void writeStdErr(String message) {
// Default doing nothing
}
@@ -141,7 +141,7 @@ public abstract class PushResultProcessing {
}
@Override
- void writeStdOut(final String message) {
+ void writeStdOut(String message) {
StartCommand command = sshCommand.get();
if (command != null) {
command.writeStdOutSync(message);
@@ -149,7 +149,7 @@ public abstract class PushResultProcessing {
}
@Override
- void writeStdErr(final String message) {
+ void writeStdErr(String message) {
StartCommand command = sshCommand.get();
if (command != null) {
command.writeStdErrSync(message);
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
index 9a68c83..86557e2 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationState.java
@@ -150,11 +150,11 @@ public class ReplicationState {
allPushTasksFinished.await();
}
- public void writeStdOut(final String message) {
+ public void writeStdOut(String message) {
pushResultProcessing.writeStdOut(message);
}
- public void writeStdErr(final String message) {
+ public void writeStdErr(String message) {
pushResultProcessing.writeStdErr(message);
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java b/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java
index f32deab..68e9652 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/SshHelper.java
@@ -68,7 +68,7 @@ class SshHelper {
}
@Override
- public synchronized void write(final int b) {
+ public synchronized void write(int b) {
if (b == '\r') {
return;
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/StartCommand.java b/src/main/java/com/googlesource/gerrit/plugins/replication/StartCommand.java
index c3f7eee..ec8d1f6 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/StartCommand.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/StartCommand.java
@@ -97,7 +97,7 @@ final class StartCommand extends SshCommand {
}
}
- public void writeStdOutSync(final String message) {
+ public void writeStdOutSync(String message) {
if (wait) {
synchronized (stdout) {
stdout.println(message);
@@ -106,7 +106,7 @@ final class StartCommand extends SshCommand {
}
}
- public void writeStdErrSync(final String message) {
+ public void writeStdErrSync(String message) {
if (wait) {
synchronized (stderr) {
stderr.println(message);