From 39bf331502ec3f6d6143c99905f8d5565946ff41 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 2 Feb 2017 10:20:00 +0900 Subject: ReplicationMetrics: Make members private final These members should only be accessed through the public methods: - start(...), to create/start a new timer context - record(...), to record the retry/delay values Mark the members as private final to prevent unintended access. Change-Id: I69a7e3b13ba4c344f3176528306163ebef07653c --- .../googlesource/gerrit/plugins/replication/ReplicationMetrics.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationMetrics.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationMetrics.java index e02084d..a7b27a0 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationMetrics.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationMetrics.java @@ -24,9 +24,9 @@ import com.google.inject.Singleton; @Singleton public class ReplicationMetrics { - Timer1 executionTime; - Histogram1 executionDelay; - Histogram1 executionRetries; + private final Timer1 executionTime; + private final Histogram1 executionDelay; + private final Histogram1 executionRetries; @Inject ReplicationMetrics(MetricMaker metricMaker) { -- cgit v1.2.3