diff options
| author | David Pursehouse <david.pursehouse@sonymobile.com> | 2015-02-03 12:17:49 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2015-02-03 12:17:49 +0900 |
| commit | 9bbffa71b3674e0f39db147e14db76a7db9fe474 (patch) | |
| tree | d9bccddd44048194e6023d1560192b1d6d120e08 /.settings | |
| parent | 6404f30051678633373630b54e1cd03a6dde8613 (diff) | |
RFC: Enable Eclipse warning about fall-through cases in switch statements
Enable the "'switch' case fall-through" warning in Eclipse to catch
unintentional fall-through to the following 'case' block when a 'break'
statement is omitted.
All warnings raised in the current codebase are caused by intentional
fall-throughs, so add "//$FALL-THROUGH$" comments to suppress those
warnings.
This change was inspired by the coverity report [1] which found the
problem in PutConfig (see CID 19880) but interestingly did not report
anything for the other ones.
RFC because I'm not sure if the "//$FALL-THROUGH$" comments will cause
the warnings to be suppressed on subsequent coverity scans.
[1] https://scan.coverity.com/projects/4032
Change-Id: Iad003bd7d086c67cccdbfb1312c8bd82d17fcc57
Diffstat (limited to '.settings')
| -rw-r--r-- | .settings/org.eclipse.jdt.core.prefs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.settings/org.eclipse.jdt.core.prefs b/.settings/org.eclipse.jdt.core.prefs index 286d59b2c2..0fa494d319 100644 --- a/.settings/org.eclipse.jdt.core.prefs +++ b/.settings/org.eclipse.jdt.core.prefs @@ -17,7 +17,7 @@ org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod= org.eclipse.jdt.core.compiler.problem.discouragedReference=warning org.eclipse.jdt.core.compiler.problem.emptyStatement=warning org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore -org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore +org.eclipse.jdt.core.compiler.problem.fallthroughCase=warning org.eclipse.jdt.core.compiler.problem.fatalOptionalError=disabled org.eclipse.jdt.core.compiler.problem.fieldHiding=warning org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning |