diff options
author | Ola Bjuremo <ola.bjuremo@tieto.com> | 2011-12-07 14:23:23 +0100 |
---|---|---|
committer | Tomas Ljunggren <tomas.ljunggren@tieto.com> | 2011-12-12 17:04:31 +0100 |
commit | 7ec4e0de6cbde9c3d8dd2a291140e02b5eb2dea6 (patch) | |
tree | 748c7a3a54a8d70d666e59d1b54c30c201f9a8d6 | |
parent | cd11f1d0065d01fc31c76e1d13e15afab7b20ba2 (diff) |
Fixed cherry pick footer settings
Cherry pick footer options were never read for projects without an access
category in the project.config file. This has now been corrected.
Task-number: QTQAINFRA-348
Change-Id: I2e8ee0da816a028969b740a5acd034d84e636a4a
Reviewed-by: Ola Bjuremo <ola.bjuremo@tieto.com>
Reviewed-by: Tomas Ljunggren <tomas.ljunggren@tieto.com>
-rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java index 7f0b74a77f..36eddef87f 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ProjectConfig.java @@ -198,10 +198,14 @@ public class ProjectConfig extends VersionedMetaData { p.setSubmitType(rc.getEnum(SUBMIT, null, KEY_ACTION, defaultSubmitAction)); p.setUseContentMerge(rc.getBoolean(SUBMIT, null, KEY_MERGE_CONTENT, false)); - + p.setIncludeOnlyMaxApproval(rc.getBoolean(CHERRY_PICK, INCLUDE_ONLY_MAX_APPROVALS, false)); p.setHideReviewedOn(rc.getBoolean(CHERRY_PICK, HIDE_REVIEWED_ON, false)); + for (String category : rc.getNames(CHERRY_PICK, CATEGORY_FOOTERS)) { + final boolean value = rc.getBoolean(CATEGORY_FOOTERS, category, true); + p.addHiddenFooter(category, value); + } accessSections = new HashMap<String, AccessSection>(); for (String refName : rc.getSubsections(ACCESS)) { if (isAccessSection(refName)) { @@ -214,16 +218,9 @@ public class ProjectConfig extends VersionedMetaData { } } } - for (String varName : rc.getNames(ACCESS, refName)) { if (isPermission(varName)) { Permission perm = as.getPermission(varName, true); - for (String category : rc.getNames(CHERRY_PICK, CATEGORY_FOOTERS)) { - final boolean value = rc.getBoolean(CATEGORY_FOOTERS, category, true); - p.addHiddenFooter(category, value); - } - - boolean useRange = perm.isLabel(); for (String ruleString : rc.getStringList(ACCESS, refName, varName)) { PermissionRule rule; |