diff options
author | David Pursehouse <dpursehouse@collab.net> | 2019-07-29 01:54:51 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-07-29 01:54:51 +0000 |
commit | f4a0305441312f5662ed3c6f97a120f993281c3f (patch) | |
tree | 05e856e14a1fb57a1ce503458cdb4bf39a8d0de2 | |
parent | 4296e093bc89a39fd073dd4057e3d59868cce608 (diff) | |
parent | 4a9a7c390a2f2755c0f230e6e916190809bf946f (diff) |
Merge "Reorder preference defaults to match member ordering"
-rw-r--r-- | java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java | 14 | ||||
-rw-r--r-- | java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java | 12 |
2 files changed, 13 insertions, 13 deletions
diff --git a/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java b/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java index 0d5bdfa01b..522ec88f77 100644 --- a/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java +++ b/java/com/google/gerrit/extensions/client/DiffPreferencesInfo.java @@ -38,7 +38,7 @@ public class DiffPreferencesInfo { IGNORE_NONE, IGNORE_TRAILING, IGNORE_LEADING_AND_TRAILING, - IGNORE_ALL; + IGNORE_ALL } public Integer context; @@ -74,18 +74,12 @@ public class DiffPreferencesInfo { i.fontSize = DEFAULT_FONT_SIZE; i.lineLength = DEFAULT_LINE_LENGTH; i.cursorBlinkRate = 0; - i.ignoreWhitespace = Whitespace.IGNORE_NONE; - i.theme = Theme.DEFAULT; i.expandAllComments = false; i.intralineDifference = true; i.manualReview = false; - i.retainHeader = false; i.showLineEndings = true; i.showTabs = true; i.showWhitespaceErrors = true; - i.skipDeleted = false; - i.skipUnchanged = false; - i.skipUncommented = false; i.syntaxHighlighting = true; i.hideTopMenu = false; i.autoHideDiffTableHeader = true; @@ -94,6 +88,12 @@ public class DiffPreferencesInfo { i.hideEmptyPane = false; i.matchBrackets = false; i.lineWrapping = false; + i.theme = Theme.DEFAULT; + i.ignoreWhitespace = Whitespace.IGNORE_NONE; + i.retainHeader = false; + i.skipDeleted = false; + i.skipUnchanged = false; + i.skipUncommented = false; return i; } } diff --git a/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java b/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java index 1f16d8d847..fa95b8fada 100644 --- a/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java +++ b/java/com/google/gerrit/extensions/client/GeneralPreferencesInfo.java @@ -151,14 +151,14 @@ public class GeneralPreferencesInfo { public ReviewCategoryStrategy reviewCategoryStrategy; public Boolean muteCommonPathPrefixes; public Boolean signedOffBy; - public List<MenuItem> my; - public List<String> changeTable; - public Map<String, String> urlAliases; public EmailStrategy emailStrategy; public EmailFormat emailFormat; public DefaultBase defaultBaseForMerges; public Boolean publishCommentsOnPush; public Boolean workInProgressByDefault; + public List<MenuItem> my; + public List<String> changeTable; + public Map<String, String> urlAliases; public boolean isShowInfoInReviewCategory() { return getReviewCategoryStrategy() != ReviewCategoryStrategy.NONE; @@ -211,9 +211,6 @@ public class GeneralPreferencesInfo { p.changesPerPage = DEFAULT_PAGESIZE; p.showSiteHeader = true; p.useFlashClipboard = true; - p.emailStrategy = EmailStrategy.ENABLED; - p.emailFormat = EmailFormat.HTML_PLAINTEXT; - p.reviewCategoryStrategy = ReviewCategoryStrategy.NONE; p.downloadScheme = null; p.downloadCommand = DownloadCommand.CHECKOUT; p.dateFormat = DateFormat.STD; @@ -224,8 +221,11 @@ public class GeneralPreferencesInfo { p.diffView = DiffView.SIDE_BY_SIDE; p.sizeBarInChangeTable = true; p.legacycidInChangeTable = false; + p.reviewCategoryStrategy = ReviewCategoryStrategy.NONE; p.muteCommonPathPrefixes = true; p.signedOffBy = false; + p.emailStrategy = EmailStrategy.ENABLED; + p.emailFormat = EmailFormat.HTML_PLAINTEXT; p.defaultBaseForMerges = DefaultBase.FIRST_PARENT; p.publishCommentsOnPush = false; p.workInProgressByDefault = false; |