diff options
author | Paladox none <thomasmulhall410@yahoo.com> | 2024-04-18 20:14:18 +0000 |
---|---|---|
committer | Paladox none <thomasmulhall410@yahoo.com> | 2024-04-21 22:34:24 +0000 |
commit | ccedf64fe81829af4e907f1ee58cb7e198a8a9e0 (patch) | |
tree | 954530b7bec4416259e3267c0eca045ea6296103 | |
parent | 7e93b969234d6b89b49db5a909f68696ebdf7368 (diff) |
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
3 files changed, 2 insertions, 21 deletions
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts index f9568f4c78..fcb9bbff03 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts @@ -928,10 +928,7 @@ export class GrFileList extends LitElement { <h3 class="assistive-tech-only">File list</h3> ${this.renderContainer()} ${this.renderChangeTotals(patchChange)} ${this.renderBinaryTotals(patchChange)} ${this.renderControlRow()} - <gr-diff-preferences-dialog - id="diffPreferencesDialog" - @reload-diff-preference=${this.handleReloadingDiffPreference} - > + <gr-diff-preferences-dialog id="diffPreferencesDialog"> </gr-diff-preferences-dialog> `; } @@ -2644,10 +2641,6 @@ export class GrFileList extends LitElement { } } - private handleReloadingDiffPreference() { - this.getUserModel().getDiffPreferences(); - } - private getOldPath(file: NormalizedFileInfo) { // The gr-endpoint-decorator is waiting until all gr-endpoint-param // values are updated. diff --git a/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts b/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts index d580127780..4457e6820f 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts @@ -12,7 +12,6 @@ import {LitElement, html, css} from 'lit'; import {customElement, query, state} from 'lit/decorators.js'; import {ValueChangedEvent} from '../../../types/events'; import {modalStyles} from '../../../styles/gr-modal-styles'; -import {fireNoBubble} from '../../../utils/event-util'; @customElement('gr-diff-preferences-dialog') export class GrDiffPreferencesDialog extends LitElement { @@ -121,7 +120,6 @@ export class GrDiffPreferencesDialog extends LitElement { assertIsDefined(this.diffPreferences, 'diffPreferences'); assertIsDefined(this.diffPrefsModal, 'diffPrefsModal'); await this.diffPreferences.save(); - fireNoBubble(this, 'reload-diff-preference', {}); this.diffPrefsModal.close(); } @@ -136,7 +134,4 @@ declare global { interface HTMLElementTagNameMap { 'gr-diff-preferences-dialog': GrDiffPreferencesDialog; } - interface HTMLElementEventMap { - 'reload-diff-preference': CustomEvent<{}>; - } } diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts index bdb634b389..a5593d69b2 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts @@ -972,10 +972,7 @@ export class GrDiffView extends LitElement { .changeNum=${this.changeNum} > </gr-apply-fix-dialog> - <gr-diff-preferences-dialog - id="diffPreferencesDialog" - @reload-diff-preference=${this.handleReloadingDiffPreference} - > + <gr-diff-preferences-dialog id="diffPreferencesDialog"> </gr-diff-preferences-dialog> <dialog id="downloadModal" tabindex="-1"> <gr-download-dialog @@ -1731,10 +1728,6 @@ export class GrDiffView extends LitElement { this.navToFile(filesWithComments, 1, true); } - private handleReloadingDiffPreference() { - this.getUserModel().getDiffPreferences(); - } - private computeCanEdit() { return ( !!this.change && |