diff options
author | Chris Poucet <poucet@google.com> | 2023-08-22 12:58:25 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2023-08-22 12:58:25 +0000 |
commit | dff51b3bca7ce09bca861cf04d52cf939cde43fd (patch) | |
tree | b5d191e56b38af29cd469b20142f374f2a626ea7 | |
parent | c6115725c49078371b56966835e5819a323292bf (diff) | |
parent | 24c9b61d7eb9d1575f4210623a4b047c10454edf (diff) |
Merge "Fix SEND_REPLY timer."
-rw-r--r-- | polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts | 2 | ||||
-rw-r--r-- | polygerrit-ui/app/models/change/change-model.ts | 11 |
2 files changed, 2 insertions, 11 deletions
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts index 80b762f7b2..8ae1c36477 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts @@ -1459,6 +1459,8 @@ export class GrReplyDialog extends LitElement { if (this.patchsetLevelGrComment) { this.patchsetLevelGrComment.disableAutoSaving = false; } + // By this point in time the change has loaded, we're only waiting for the comments. + this.reporting.timeEnd(Timing.SEND_REPLY); }); } diff --git a/polygerrit-ui/app/models/change/change-model.ts b/polygerrit-ui/app/models/change/change-model.ts index af6906381a..acae8add8d 100644 --- a/polygerrit-ui/app/models/change/change-model.ts +++ b/polygerrit-ui/app/models/change/change-model.ts @@ -369,7 +369,6 @@ export class ChangeModel extends Model<ChangeState> { this.setDiffTitle(), this.setEditTitle(), this.reportChangeReload(), - this.reportSendReply(), this.fireShowChange(), this.refuseEditForOpenChange(), this.refuseEditForClosedChange(), @@ -384,16 +383,6 @@ export class ChangeModel extends Model<ChangeState> { ]; } - private reportSendReply() { - return this.changeLoadingStatus$.subscribe(loadingStatus => { - // We are ending the timer on each change load, because ending a timer - // that was not started is a no-op. :-) - if (loadingStatus === LoadingStatus.LOADED) { - this.reporting.timeEnd(Timing.SEND_REPLY); - } - }); - } - private reportChangeReload() { return this.changeLoadingStatus$.subscribe(loadingStatus => { if ( |