Allow assigning Push for refs/meta/config on All-Projects

The refs/meta/config branch of the All-Projects project should only be
modified by Gerrit administrators because being able to do
modifications on this branch means that the user could assign himself
administrator permissions.

In addition to being administrator we already require that the
administrator has the Push access right for refs/meta/config in order
to be able to modify it (just as with all other branches
administrators do not have edit permissions by default).

The problem was that assigning the Push access right for
refs/meta/config on the All-Projects project was not allowed.

Having the Push access right for refs/meta/config on the All-Projects
project without being administrator already has no effect.

Prohibiting to assign the Push access right for refs/meta/config on the
All-Project project was anyway pointless since it was e.g. possible to
assign the Push access right on refs/meta/*.

Change-Id: I0640c5b3a479b31120d28c1af0c3112ccbbd555e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>

1 files changed, 0 insertions, 3 deletions

diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java b/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java
index 5cb7787505..fd408887cf 100644
--- a/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java
+++ b/gerrit-common/src/main/java/com/google/gerrit/common/data/Permission.java
@@ -80,9 +80,6 @@ public class Permission implements Comparable<Permission> {
     if (AccessSection.ALL.equals(ref)) {
       return !OWNER.equals(permissionName);
     }
-    if (AccessSection.REF_CONFIG.equals(ref)) {
-      return !PUSH.equals(permissionName);
-    }
     return true;
   }