summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Pursehouse <david.pursehouse@sonymobile.com>2013-02-06 10:24:14 +0900
committerDavid Pursehouse <david.pursehouse@sonymobile.com>2013-02-06 10:26:10 +0900
commit75013b8b0a5d5d4f0873f1a49712adaba3c19b89 (patch)
tree76ff115cf023245986823ad58ee4c48a49ce9ba5
parent5b884b53320e0092a9db91532343ab465684f7e6 (diff)
Update 2.5.2 release notes with info about commit-msg hook fix
-rw-r--r--ReleaseNotes/ReleaseNotes-2.5.2.txt14
1 files changed, 14 insertions, 0 deletions
diff --git a/ReleaseNotes/ReleaseNotes-2.5.2.txt b/ReleaseNotes/ReleaseNotes-2.5.2.txt
index 0a54b7944a..76d36d80f4 100644
--- a/ReleaseNotes/ReleaseNotes-2.5.2.txt
+++ b/ReleaseNotes/ReleaseNotes-2.5.2.txt
@@ -90,3 +90,17 @@ was malformed.
+
The link to the repo command reference in the 'repo upload' section of
the 'Uploading Changes' documentation was broken.
+
+* link:http://code.google.com/p/gerrit/issues/detail?id=1569[issue 1569]:
+Fix unexpected behaviour in the commit-msg hook caused by `GREP_OPTIONS`
++
+If `GREP_OPTIONS` was set, it caused unexpected behaviour in the
+commit-msg hook. For example if it included a setting like
+`--exclude=".git/*"` it caused a new `Change-Id` line to be appended
+to the commit message on every amend.
++
+`GREP_OPTIONS` is now unset at the beginning of the commit-msg script
+to prevent such problems from occurring.
++
+The `GREP_OPTIONS` setting in the user's environment is unaffected
+by this change.