summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaladox none <thomasmulhall410@yahoo.com>2021-07-07 02:34:53 +0000
committerPaladox none <thomasmulhall410@yahoo.com>2021-07-07 20:39:21 +0000
commit796f819cd1c9c0ac8689e130349d3ae1b6e65fb2 (patch)
tree54cd2b94b03a8ec0a69e956dbec146637dbf890f
parentf500af8500d81710b2ba0fa83779ee887ec9ee2b (diff)
Fix edit url when saving
It set /edit rather than ,edit. Change-Id: I4e8112e91b565875359f53bf9c8eb06b2670d14d (cherry picked from commit 622903a3f4955229cc27993b6d0353c40c8fe3a7)
-rw-r--r--polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js4
-rw-r--r--polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html11
2 files changed, 4 insertions, 11 deletions
diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js
index d2ffa566fa..b766e7f903 100644
--- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js
+++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js
@@ -184,9 +184,7 @@ class GrEditorView extends mixinBehaviors( [
}
_viewEditInChangeView() {
- const patch = this._successfulSave ? this.EDIT_NAME : this._patchNum;
- GerritNav.navigateToChange(this._change, patch, null,
- patch !== this.EDIT_NAME);
+ GerritNav.navigateToChange(this._change, undefined, undefined, true);
}
_getFileData(changeNum, path, patchNum) {
diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html
index e385854f51..f353a1c31b 100644
--- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html
+++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view_test.html
@@ -297,18 +297,13 @@ suite('gr-editor-view tests', () => {
element._showAlert('test message');
});
- test('_viewEditInChangeView respects _patchNum', () => {
+ test('_viewEditInChangeView', () => {
navigateStub.restore();
const navStub = sandbox.stub(GerritNav, 'navigateToChange');
element._patchNum = element.EDIT_NAME;
element._viewEditInChangeView();
- assert.equal(navStub.lastCall.args[1], element.EDIT_NAME);
- element._patchNum = '1';
- element._viewEditInChangeView();
- assert.equal(navStub.lastCall.args[1], '1');
- element._successfulSave = true;
- element._viewEditInChangeView();
- assert.equal(navStub.lastCall.args[1], element.EDIT_NAME);
+ assert.equal(navStub.lastCall.args[1], undefined);
+ assert.equal(navStub.lastCall.args[3], true);
});
suite('keyboard shortcuts', () => {