diff options
author | Prudhvi Akhil Alahari <prudhvi@codeaurora.org> | 2021-05-27 10:54:26 +0530 |
---|---|---|
committer | Prudhvi Akhil Alahari <prudhvi@codeaurora.org> | 2021-05-27 10:54:26 +0530 |
commit | 91b79bec1fd2298782ce0c53a54e95683f3eafb2 (patch) | |
tree | 0d536c87d5e357f749c53517b2c0366b30af97cf | |
parent | ff08eb8008e203cce7530b037279c11bfccc218c (diff) | |
parent | eccea540a31c8171aee451519952be711ad98ac5 (diff) |
Merge branch 'stable-2.15' into stable-2.16
* stable-2.15:
Fix to not throw NPE while accessing draft refs
EqualsLabelPredicate: Fix bug that prevents matching owner votes
Change-Id: Ieba3fc1cb0ead80a54c3ec55ba6e7f0f574405dc
-rw-r--r-- | java/com/google/gerrit/server/query/change/ChangeData.java | 2 | ||||
-rw-r--r-- | java/com/google/gerrit/server/query/change/EqualsLabelPredicate.java | 12 |
2 files changed, 11 insertions, 3 deletions
diff --git a/java/com/google/gerrit/server/query/change/ChangeData.java b/java/com/google/gerrit/server/query/change/ChangeData.java index 8e9a08f2e7..23c3e2e226 100644 --- a/java/com/google/gerrit/server/query/change/ChangeData.java +++ b/java/com/google/gerrit/server/query/change/ChangeData.java @@ -1078,7 +1078,7 @@ public class ChangeData { draftsByUser = new HashMap<>(); if (notesMigration.readChanges()) { - for (Ref ref : commentsUtil.getDraftRefs(notes.getChangeId())) { + for (Ref ref : commentsUtil.getDraftRefs(notes().getChangeId())) { Account.Id account = Account.Id.fromRefSuffix(ref.getName()); if (account != null // Double-check that any drafts exist for this user after diff --git a/java/com/google/gerrit/server/query/change/EqualsLabelPredicate.java b/java/com/google/gerrit/server/query/change/EqualsLabelPredicate.java index 54e22f328d..6975ae5a2f 100644 --- a/java/com/google/gerrit/server/query/change/EqualsLabelPredicate.java +++ b/java/com/google/gerrit/server/query/change/EqualsLabelPredicate.java @@ -107,12 +107,20 @@ public class EqualsLabelPredicate extends ChangeIndexPredicate { return null; } - protected boolean match(ChangeData cd, short value, Account.Id approver) { + protected boolean match(ChangeData cd, short value, Account.Id approver) throws OrmException { if (value != expVal) { return false; } - if (account != null && !account.equals(approver)) { + if (account != null + && !account.equals(approver) + && !account.equals(ChangeQueryBuilder.OWNER_ACCOUNT_ID)) { + return false; + } + + if (account != null + && account.equals(ChangeQueryBuilder.OWNER_ACCOUNT_ID) + && !cd.change().getOwner().equals(approver)) { return false; } |