diff options
| author | Diego Zambelli Sessona <diego.sessona@gmail.com> | 2024-03-19 15:39:43 +0100 |
|---|---|---|
| committer | Diego Zambelli Sessona <diego.sessona@gmail.com> | 2024-03-19 15:46:39 +0100 |
| commit | 371b0687e9ed9cc3ebb489e6f28e1058e064d807 (patch) | |
| tree | 4600b5d12c39ecb7e3e9032c9f6f87d417817ae5 | |
| parent | db911c50c6d87d92da8f0c78dcf9063974269a18 (diff) | |
Move comment of PaginatingSource.read()
Move the comment about restarting the DataSource for back filling
results skipped for visibility. The comment in fact is valid for
any PaginationType specified.
Adress the comment in change 413358 [1].
[1]: https://gerrit-review.googlesource.com/c/gerrit/+/413358/comment/d7a90bb0_0f8ebc9f/
Release-Notes: skip
Change-Id: I9826b8be4005a946c7952ae89eb81f8c191997e3
| -rw-r--r-- | java/com/google/gerrit/index/query/PaginatingSource.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/java/com/google/gerrit/index/query/PaginatingSource.java b/java/com/google/gerrit/index/query/PaginatingSource.java index 8847005629..9ec64e63e0 100644 --- a/java/com/google/gerrit/index/query/PaginatingSource.java +++ b/java/com/google/gerrit/index/query/PaginatingSource.java @@ -67,14 +67,14 @@ public class PaginatingSource<T> implements DataSource<T> { } if (last != null && source instanceof Paginated) { + // Restart source and continue if we have not filled the + // full limit the caller wants. + // // TODO: this fix is only for the stable branches and the real refactoring would be to // restore the logic // for the filtering in AndSource (L58 - 64) as per // https://gerrit-review.googlesource.com/c/gerrit/+/345634/9 if (!indexConfig.paginationType().equals(PaginationType.NONE)) { - // Restart source and continue if we have not filled the - // full limit the caller wants. - // @SuppressWarnings("unchecked") Paginated<T> p = (Paginated<T>) source; QueryOptions opts = p.getOptions(); |