summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNasser Grainawi <nasser.grainawi@linaro.org>2023-12-04 23:54:01 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2023-12-04 23:54:01 +0000
commit50ac9f4854ae5f24cf4c3a6f4249b52825101718 (patch)
tree86cc66abdc5e99d8abf973710e065f1da89dd92e
parent0838d0ed4a1176b47c9e808793348c0b40737f5e (diff)
parentbb102712f1682228df10587851194d0cb8fa087d (diff)
Merge "GroupCacheImpl: Fix timer to include the correct method" into stable-3.5
-rw-r--r--java/com/google/gerrit/server/account/GroupCacheImpl.java11
1 files changed, 8 insertions, 3 deletions
diff --git a/java/com/google/gerrit/server/account/GroupCacheImpl.java b/java/com/google/gerrit/server/account/GroupCacheImpl.java
index eaec9baecd..36f725f56d 100644
--- a/java/com/google/gerrit/server/account/GroupCacheImpl.java
+++ b/java/com/google/gerrit/server/account/GroupCacheImpl.java
@@ -283,7 +283,7 @@ public class GroupCacheImpl implements GroupCache {
List<Cache.GroupKeyProto> keyList = new ArrayList<>();
try (TraceTimer ignored =
TraceContext.newTimer(
- "Loading group from serialized cache",
+ "Building keys to load group(s) from serialized cache",
Metadata.builder().cacheName(BYUUID_NAME_PERSISTED).build());
Repository allUsers = repoManager.openRepository(allUsersName)) {
while (uuidIterator.hasNext()) {
@@ -302,8 +302,13 @@ public class GroupCacheImpl implements GroupCache {
keyList.add(key);
}
}
- persistedCache.getAll(keyList).entrySet().stream()
- .forEach(g -> toReturn.put(g.getKey().getUuid(), Optional.of(g.getValue())));
+ try (TraceTimer ignored =
+ TraceContext.newTimer(
+ "Loading group(s) from serialized cache",
+ Metadata.builder().cacheName(BYUUID_NAME_PERSISTED).build())) {
+ persistedCache.getAll(keyList).entrySet().stream()
+ .forEach(g -> toReturn.put(g.getKey().getUuid(), Optional.of(g.getValue())));
+ }
return toReturn;
}
}