diff options
| author | Chris Poucet <poucet@google.com> | 2024-04-09 15:25:30 +0200 |
|---|---|---|
| committer | Paladox none <thomasmulhall410@yahoo.com> | 2024-04-09 14:16:40 +0000 |
| commit | 95d1d88589b32b54ea473708bd590608917d3b5f (patch) | |
| tree | 6425d2cf96de1db915e78eb5f94d7ee4bc62bf7a | |
| parent | 46c9fd3e573d02e39aacaad1911a0ee8994f74c2 (diff) | |
Fix a bug with paper-tooltip.
We need to set properties, not attributes for paper-tooltip.
Google-Bug-Id: b/333416564
Release-Notes: skip
Change-Id: I48d41184d10aa0b2fd719717c38664792fa8bc54
(cherry picked from commit 4f7449246c08c9d6066ebbf5dca54423d07a9afc)
| -rw-r--r-- | polygerrit-ui/app/elements/checks/gr-checks-results.ts | 4 | ||||
| -rw-r--r-- | polygerrit-ui/app/elements/checks/gr-checks-results_test.ts | 9 |
2 files changed, 3 insertions, 10 deletions
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts index 848948f05d..e1604cf38a 100644 --- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts +++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts @@ -495,7 +495,7 @@ export class GrResultRow extends LitElement { return html` <div class="label ${status}"> <span>${label} ${valueStr}</span> - <paper-tooltip offset="5" ?fitToVisibleBounds=${true}> + <paper-tooltip offset="5" .fitToVisibleBounds=${true}> The check result has (probably) influenced this label vote. </paper-tooltip> </div> @@ -607,7 +607,7 @@ export class GrResultRow extends LitElement { @click=${(e: MouseEvent) => this.tagClick(e, tag.name)} > <span>${tag.name}</span> - <paper-tooltip offset="5" ?fitToVisibleBounds=${true}> + <paper-tooltip offset="5" .fitToVisibleBounds=${true}> ${tag.tooltip ?? 'A category tag for this check result. Click to filter.'} </paper-tooltip> diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts b/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts index 934e9585dd..15176b0c40 100644 --- a/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts +++ b/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts @@ -45,12 +45,7 @@ suite('gr-result-row test', () => { /* HTML */ ` <div class="approved label"> <span> test-label +1 </span> - <paper-tooltip - fittovisiblebounds="" - offset="5" - role="tooltip" - tabindex="-1" - > + <paper-tooltip offset="5" role="tooltip" tabindex="-1"> The check result has (probably) influenced this label vote. </paper-tooltip> </div> @@ -92,7 +87,6 @@ suite('gr-result-row test', () => { <button class="tag"> <span> OBSOLETE </span> <paper-tooltip - fittovisiblebounds="" offset="5" role="tooltip" tabindex="-1" @@ -103,7 +97,6 @@ suite('gr-result-row test', () => { <button class="tag"> <span> E2E </span> <paper-tooltip - fittovisiblebounds="" offset="5" role="tooltip" tabindex="-1" |