diff options
| author | Milutin Kristofic <milutin@google.com> | 2024-04-09 19:29:05 +0200 |
|---|---|---|
| committer | Paladox none <thomasmulhall410@yahoo.com> | 2024-04-10 12:03:43 +0000 |
| commit | d83118ab25104266ccee5a620460dddac97d5b11 (patch) | |
| tree | 67d4659eeacd349a62983f4e9ef2364dab8c20e0 | |
| parent | 221387dcadba69464e9d98c0d1669960bc336200 (diff) | |
Fix large event_details in dashboard displayed
In our logs we found out event details with over 750k characters
and daily max around 100k characters. This is caused only by
dashboard displayed that can accumulate large rpcList when it is
refreshing without router change location.
This special case was introduced in Change 350774.
Release-Notes: skip
Google-Bug-Id: b/330373302
Change-Id: I9052621367ce3efe4c73f321b13bce53b6ddc1e5
(cherry picked from commit 6e6f42e4e7fd59b6e248ed1f45e8d14b5bff2334)
| -rw-r--r-- | polygerrit-ui/app/services/gr-reporting/gr-reporting_impl.ts | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/polygerrit-ui/app/services/gr-reporting/gr-reporting_impl.ts b/polygerrit-ui/app/services/gr-reporting/gr-reporting_impl.ts index 55bb64cbd7..cc54c4a16d 100644 --- a/polygerrit-ui/app/services/gr-reporting/gr-reporting_impl.ts +++ b/polygerrit-ui/app/services/gr-reporting/gr-reporting_impl.ts @@ -676,6 +676,12 @@ export class GrReporting implements ReportingService, Finalizable { time(name: Timing) { this._baselines[name] = now(); window.performance.mark(`${name}-start`); + // When time(Timing.DASHBOARD_DISPLAYED) is called gr-dashboard-view + // we need to clean-up slowRpcList, otherwise it can accumulate to big size + if (name === Timing.DASHBOARD_DISPLAYED) { + this.slowRpcList = []; + this.hiddenDurationTimer.reset(); + } } /** |