diff options
| author | Shawn O. Pearce <sop@google.com> | 2009-01-30 14:00:55 -0800 |
|---|---|---|
| committer | Shawn O. Pearce <sop@google.com> | 2009-01-30 14:00:55 -0800 |
| commit | 9636d646317c18a916b83272d9cfb84f17dcc0e5 (patch) | |
| tree | 0887257cbc340886a8ac08521bb49ed086ce5763 | |
| parent | 9e727d346a7137b567657839a0d93d815faea3c6 (diff) | |
Don't create editors in the line number column of a side-by-site diff
Its horrible to construct an editor into the line number column;
it completely throws off the UI layout of the entire window.
Signed-off-by: Shawn O. Pearce <sop@google.com>
| -rw-r--r-- | appjar/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/appjar/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java b/appjar/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java index e818bb9ddf..4a09d24897 100644 --- a/appjar/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java +++ b/appjar/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java @@ -39,10 +39,14 @@ public class SideBySideTable extends AbstractPatchContentTable { } @Override - protected void onCellDoubleClick(final int row, final int column) { - if (column > 1 && getRowItem(row) instanceof SideBySideLineList) { + protected void onCellDoubleClick(final int row, int column) { + if (column > 0 && getRowItem(row) instanceof SideBySideLineList) { final SideBySideLineList pl = (SideBySideLineList) getRowItem(row); final short file = (short) ((column - 1) / 2); + if (column < (1 + file * 2 + 1)) { + column++; + } + final SideBySideLine line = pl.lines.get(file); switch (line.getType()) { case DELETE: |