diff options
author | Shawn O. Pearce <sop@google.com> | 2009-01-27 18:29:03 -0800 |
---|---|---|
committer | Shawn O. Pearce <sop@google.com> | 2009-01-27 18:29:03 -0800 |
commit | b4f01838f33d857a1a350a5ceaae8ea42f53423a (patch) | |
tree | 1516fbaab38739f19a114e1d5f01eef9e1fc076c | |
parent | 43473176853da388bf3a699d89c33e19e5302eb8 (diff) |
Fix category value initialization to use the category's transaction
I missed the ", txn" on each of these insert calls, allowing the
category to possibly create without its range of values.
Signed-off-by: Shawn O. Pearce <sop@google.com>
-rw-r--r-- | appjar/src/main/java/com/google/gerrit/server/GerritServer.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/appjar/src/main/java/com/google/gerrit/server/GerritServer.java b/appjar/src/main/java/com/google/gerrit/server/GerritServer.java index b2bc9a5008..d4928f2dd3 100644 --- a/appjar/src/main/java/com/google/gerrit/server/GerritServer.java +++ b/appjar/src/main/java/com/google/gerrit/server/GerritServer.java @@ -254,7 +254,7 @@ public class GerritServer { vals.add(value(cat, 0, "No score")); vals.add(value(cat, -1, "Fails")); c.approvalCategories().insert(Collections.singleton(cat), txn); - c.approvalCategoryValues().insert(vals); + c.approvalCategoryValues().insert(vals, txn); txn.commit(); } @@ -272,7 +272,7 @@ public class GerritServer { vals.add(value(cat, -1, "I would prefer that you didn't submit this")); vals.add(value(cat, -2, "Do not submit")); c.approvalCategories().insert(Collections.singleton(cat), txn); - c.approvalCategoryValues().insert(vals); + c.approvalCategoryValues().insert(vals, txn); txn.commit(); final ProjectRight approve = @@ -295,7 +295,7 @@ public class GerritServer { vals.add(value(cat, 1, "Read access")); vals.add(value(cat, -1, "No access")); c.approvalCategories().insert(Collections.singleton(cat), txn); - c.approvalCategoryValues().insert(vals); + c.approvalCategoryValues().insert(vals, txn); txn.commit(); { final ProjectRight read = @@ -326,7 +326,7 @@ public class GerritServer { vals = new ArrayList<ApprovalCategoryValue>(); vals.add(value(cat, 1, "Submit")); c.approvalCategories().insert(Collections.singleton(cat), txn); - c.approvalCategoryValues().insert(vals); + c.approvalCategoryValues().insert(vals, txn); txn.commit(); } |