Fix warning about debug code in OpenIdServiceImpl

This code is here only for aid while debugging an OpenID exchange,
which doesn't happen that often.  Pulling it out to an isolated
method and tagging it to ignore unchecked casts fixes a warning in
this class.

Signed-off-by: Shawn O. Pearce <sop@google.com>

1 files changed, 13 insertions, 8 deletions

diff --git a/src/main/java/com/google/gerrit/server/OpenIdServiceImpl.java b/src/main/java/com/google/gerrit/server/OpenIdServiceImpl.java
index 4f52f41313..f908b22a09 100644
--- a/src/main/java/com/google/gerrit/server/OpenIdServiceImpl.java
+++ b/src/main/java/com/google/gerrit/server/OpenIdServiceImpl.java
@@ -213,14 +213,7 @@ class OpenIdServiceImpl implements OpenIdService {
   void doAuth(final HttpServletRequest req, final HttpServletResponse rsp)
       throws Exception {
     if (false) {
-      System.err.println(req.getMethod() + " /login");
-      for (final String n : new TreeMap<String, Object>(req.getParameterMap())
-          .keySet()) {
-        for (final String v : req.getParameterValues(n)) {
-          System.err.println("  " + n + "=" + v);
-        }
-      }
-      System.err.println();
+      debugRequest(req);
     }
 
     final String openidMode = req.getParameter(OPENID_MODE);
@@ -316,6 +309,18 @@ class OpenIdServiceImpl implements OpenIdService {
     }
   }
 
+  @SuppressWarnings("unchecked")
+  private static void debugRequest(final HttpServletRequest req) {
+    System.err.println(req.getMethod() + " /login");
+    for (final String n : new TreeMap<String, Object>(req.getParameterMap())
+        .keySet()) {
+      for (final String v : req.getParameterValues(n)) {
+        System.err.println("  " + n + "=" + v);
+      }
+    }
+    System.err.println();
+  }
+
   private void initializeAccount(final HttpServletRequest req,
       final HttpServletResponse rsp, final Identifier user,
       final String fullname, final String email) throws IOException {