Use ValueChangedHandler for CheckBox update events in PatchScreen

This is more correct, because GWT installs keyboard handlers as
well as mouse click handlers to ensure the application is called
when the value of the check box changes.  Otherwise we may see
spurious events, or miss events entirely.

Signed-off-by: Shawn O. Pearce <sop@google.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/src/main/java/com/google/gerrit/client/patches/PatchScreen.java b/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
index ab93f82822..b66b61cf1a 100644
--- a/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
+++ b/src/main/java/com/google/gerrit/client/patches/PatchScreen.java
@@ -33,9 +33,9 @@ import com.google.gerrit.client.rpc.GerritCallback;
 import com.google.gerrit.client.rpc.NoDifferencesException;
 import com.google.gerrit.client.ui.ChangeLink;
 import com.google.gerrit.client.ui.Screen;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
+import com.google.gwt.event.logical.shared.ValueChangeHandler;
 import com.google.gwt.user.client.History;
-import com.google.gwt.event.dom.client.ClickEvent;
-import com.google.gwt.event.dom.client.ClickHandler;
 import com.google.gwt.user.client.ui.CheckBox;
 import com.google.gwt.user.client.ui.DisclosurePanel;
 import com.google.gwt.user.client.ui.FlowPanel;
@@ -184,10 +184,10 @@ public abstract class PatchScreen extends Screen {
 
   private Widget createShowFullFiles() {
     final CheckBox cb = new CheckBox(PatchUtil.C.showFullFiles());
-    cb.addClickHandler(new ClickHandler() {
+    cb.addValueChangeHandler(new ValueChangeHandler<Boolean>() {
       @Override
-      public void onClick(ClickEvent arg0) {
-        if (cb.getValue()) {
+      public void onValueChange(ValueChangeEvent<Boolean> event) {
+        if (event.getValue()) {
           // Show a diff of the full files
           scriptSettings.setContext(WHOLE_FILE_CONTEXT);
         } else {
@@ -202,10 +202,10 @@ public abstract class PatchScreen extends Screen {
 
   private Widget createIgnoreWhitespace() {
     final CheckBox cb = new CheckBox(PatchUtil.C.ignoreWhitespace());
-    cb.addClickHandler(new ClickHandler() {
+    cb.addValueChangeHandler(new ValueChangeHandler<Boolean>() {
       @Override
-      public void onClick(ClickEvent arg0) {
-        if (cb.getValue()) {
+      public void onValueChange(ValueChangeEvent<Boolean> event) {
+        if (event.getValue()) {
           scriptSettings.setWhitespace(IGNORE_SPACE_CHANGE);
         } else {
           scriptSettings.setWhitespace(IGNORE_NONE);