diff options
| author | Shawn O. Pearce <sop@google.com> | 2009-02-13 10:47:35 -0800 |
|---|---|---|
| committer | Shawn O. Pearce <sop@google.com> | 2009-02-13 10:58:55 -0800 |
| commit | 443abc057487b8fa196df146d7ca3b79185e830a (patch) | |
| tree | 9d548e3f5007cf0a09afbca92d996c747b78c370 | |
| parent | b97bd5e42a0e4bee99f7554d2e25da90f0a84333 (diff) | |
Make 'c', 'r' in a patch view open a new comment editor
Like enter, these open a new comment editor for the current line.
Signed-off-by: Shawn O. Pearce <sop@google.com>
| -rw-r--r-- | src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java | 11 | ||||
| -rw-r--r-- | src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java | 2 |
2 files changed, 12 insertions, 1 deletions
diff --git a/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java b/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java index 90fb66e68e..f9e109791b 100644 --- a/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java +++ b/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java @@ -107,6 +107,17 @@ public abstract class AbstractPatchContentTable extends FancyFlexTable<Object> { case KeyboardListener.KEY_UP: case KeyboardListener.KEY_DOWN: return false; + + case 'c': + case 'r': + for (int row = getCurrentRow(); 0 <= row; row--) { + final Object item = getRowItem(row); + if (!(item instanceof CommentList) && item != null) { + onOpenItem(item); + break; + } + } + return true; } } return super.onKeyPress(keyCode, modifiers); diff --git a/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java b/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java index f3802a9018..14c075fc48 100644 --- a/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java +++ b/src/main/java/com/google/gerrit/client/ui/FancyFlexTable.java @@ -155,7 +155,7 @@ public abstract class FancyFlexTable<RowItem> extends Composite implements } } - private void onOpen() { + protected void onOpen() { if (0 <= currentRow && currentRow < table.getRowCount()) { final RowItem item = getRowItem(currentRow); if (item != null) { |