diff options
| author | Shawn O. Pearce <sop@google.com> | 2009-02-06 16:58:51 -0800 |
|---|---|---|
| committer | Shawn O. Pearce <sop@google.com> | 2009-02-06 16:58:51 -0800 |
| commit | b97a109a9cab8dbeb3aab0c89c818307470548df (patch) | |
| tree | 49c89ca8f638d788b1c7f659be362fa14806440d | |
| parent | 11a16f8b59ac8be302c0ef58d9a1eb059f4f530e (diff) | |
Yank the mobile specific OpenID login panel
The browser selection doesn't work, at least on Android. Until
I figure out what is going on I'm removing the variant from the
build so it takes less time to compile.
Signed-off-by: Shawn O. Pearce <sop@google.com>
| -rw-r--r-- | src/main/java/com/google/gerrit/UserAgent.gwt.xml | 23 | ||||
| -rw-r--r-- | src/main/java/com/google/gerrit/client/openid/AllowFrameImplMobile.java | 24 |
2 files changed, 0 insertions, 47 deletions
diff --git a/src/main/java/com/google/gerrit/UserAgent.gwt.xml b/src/main/java/com/google/gerrit/UserAgent.gwt.xml index 54f25fb0a0..a7284cf8f7 100644 --- a/src/main/java/com/google/gerrit/UserAgent.gwt.xml +++ b/src/main/java/com/google/gerrit/UserAgent.gwt.xml @@ -1,28 +1,5 @@ <module> - <define-property name="extUserAgent" values="mobile"/> - <property-provider name="extUserAgent"><![CDATA[ - var ua = navigator.userAgent.toLowerCase(); - - if (ua.indexOf("safari") != -1) { - if (ua.indexOf("iphone") != -1) - return "mobile"; - if (ua.indexOf("ipod") != -1) - return "mobile"; - if (ua.indexOf("android") != -1) - return "mobile"; - } - return "unknown"; - ]]></property-provider> - <!-- openid.AllowFrameImpl --> - <replace-with class="com.google.gerrit.client.openid.AllowFrameImplMobile"> - <when-type-is class="com.google.gerrit.client.openid.AllowFrameImpl" /> - <any> - <when-property-is name="user.agent" value="safari"/> - <when-property-is name="extUserAgent" value="mobile"/> - </any> - </replace-with> - <replace-with class="com.google.gerrit.client.openid.AllowFrameImplSafari"> <when-type-is class="com.google.gerrit.client.openid.AllowFrameImpl" /> <any> diff --git a/src/main/java/com/google/gerrit/client/openid/AllowFrameImplMobile.java b/src/main/java/com/google/gerrit/client/openid/AllowFrameImplMobile.java deleted file mode 100644 index c5199d2aac..0000000000 --- a/src/main/java/com/google/gerrit/client/openid/AllowFrameImplMobile.java +++ /dev/null @@ -1,24 +0,0 @@ -// Copyright 2009 Google Inc. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gerrit.client.openid; - -class AllowFrameImplMobile extends AllowFrameImpl { - @Override - boolean permit(final String url) { - // Working an IFRAME on a tiny device is difficult. - // - return false; - } -} |