Bold substrings which match query when showing completions

This is simply a common idiom for completion widgets on the web.
The fact that GWT 1.5.3 doesn't provide it out of the box is a
bit disturbing, but we can easily implement it by inheriting off
gwtexpui's new HighlightSuggestOracle class.

Signed-off-by: Shawn O. Pearce <sop@google.com>

4 files changed, 10 insertions, 7 deletions

diff --git a/pom.xml b/pom.xml
index c9168fbfa9..0440d83c4e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -444,7 +444,7 @@ limitations under the License.
     <dependency>
       <groupId>gwtexpui</groupId>
       <artifactId>gwtexpui</artifactId>
-      <version>1.0</version>
+      <version>1.0.1-SNAPSHOT</version>
       <scope>compile</scope>
     </dependency>
 
diff --git a/src/main/java/com/google/gerrit/client/ui/AccountGroupSuggestOracle.java b/src/main/java/com/google/gerrit/client/ui/AccountGroupSuggestOracle.java
index 8797702498..d77a6c10a5 100644
--- a/src/main/java/com/google/gerrit/client/ui/AccountGroupSuggestOracle.java
+++ b/src/main/java/com/google/gerrit/client/ui/AccountGroupSuggestOracle.java
@@ -18,14 +18,15 @@ import com.google.gerrit.client.RpcStatus;
 import com.google.gerrit.client.reviewdb.AccountGroup;
 import com.google.gerrit.client.rpc.GerritCallback;
 import com.google.gwt.user.client.ui.SuggestOracle;
+import com.google.gwtexpui.safehtml.client.HighlightSuggestOracle;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /** Suggestion Oracle for AccountGroup entities. */
-public class AccountGroupSuggestOracle extends SuggestOracle {
+public class AccountGroupSuggestOracle extends HighlightSuggestOracle {
   @Override
-  public void requestSuggestions(final Request req, final Callback callback) {
+  public void onRequestSuggestions(final Request req, final Callback callback) {
     RpcStatus.hide(new Runnable() {
       public void run() {
         SuggestUtil.SVC.suggestAccountGroup(req.getQuery(), req.getLimit(),
diff --git a/src/main/java/com/google/gerrit/client/ui/AccountSuggestOracle.java b/src/main/java/com/google/gerrit/client/ui/AccountSuggestOracle.java
index 0e97ced3c0..981024e6a0 100644
--- a/src/main/java/com/google/gerrit/client/ui/AccountSuggestOracle.java
+++ b/src/main/java/com/google/gerrit/client/ui/AccountSuggestOracle.java
@@ -19,14 +19,15 @@ import com.google.gerrit.client.RpcStatus;
 import com.google.gerrit.client.data.AccountInfo;
 import com.google.gerrit.client.rpc.GerritCallback;
 import com.google.gwt.user.client.ui.SuggestOracle;
+import com.google.gwtexpui.safehtml.client.HighlightSuggestOracle;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /** Suggestion Oracle for Account entities. */
-public class AccountSuggestOracle extends SuggestOracle {
+public class AccountSuggestOracle extends HighlightSuggestOracle {
   @Override
-  public void requestSuggestions(final Request req, final Callback callback) {
+  public void onRequestSuggestions(final Request req, final Callback callback) {
     RpcStatus.hide(new Runnable() {
       public void run() {
         SuggestUtil.SVC.suggestAccount(req.getQuery(), req.getLimit(),
diff --git a/src/main/java/com/google/gerrit/client/ui/ProjectNameSuggestOracle.java b/src/main/java/com/google/gerrit/client/ui/ProjectNameSuggestOracle.java
index 74257408b0..3d003b11e8 100644
--- a/src/main/java/com/google/gerrit/client/ui/ProjectNameSuggestOracle.java
+++ b/src/main/java/com/google/gerrit/client/ui/ProjectNameSuggestOracle.java
@@ -18,14 +18,15 @@ import com.google.gerrit.client.RpcStatus;
 import com.google.gerrit.client.reviewdb.Project;
 import com.google.gerrit.client.rpc.GerritCallback;
 import com.google.gwt.user.client.ui.SuggestOracle;
+import com.google.gwtexpui.safehtml.client.HighlightSuggestOracle;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /** Suggestion Oracle for Project.NameKey entities. */
-public class ProjectNameSuggestOracle extends SuggestOracle {
+public class ProjectNameSuggestOracle extends HighlightSuggestOracle {
   @Override
-  public void requestSuggestions(final Request req, final Callback callback) {
+  public void onRequestSuggestions(final Request req, final Callback callback) {
     RpcStatus.hide(new Runnable() {
       public void run() {
         SuggestUtil.SVC.suggestProjectNameKey(req.getQuery(), req.getLimit(),