summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShawn O. Pearce <sop@google.com>2009-03-30 13:30:04 -0700
committerShawn O. Pearce <sop@google.com>2009-03-30 13:30:04 -0700
commit7a1ee1dc817a714a0dedf20b606e6b77ce503ed3 (patch)
tree12b5068647c39dce23060a8f2ab89ae2c980359f
parente97780dd90012f6ac4eeb85824e1632ed0971678 (diff)
Handle unwrapped commit message more gracefully
By moving the info block on the change screen to the left side of the commit message rather then the right, only the commit message suffers when its longer than the expected size of ~70 characters wide. Bug: GERRIT-35 Signed-off-by: Shawn O. Pearce <sop@google.com>
-rw-r--r--src/main/java/com/google/gerrit/client/GerritCss.css1
-rw-r--r--src/main/java/com/google/gerrit/client/changes/ChangeDescriptionBlock.java7
2 files changed, 2 insertions, 6 deletions
diff --git a/src/main/java/com/google/gerrit/client/GerritCss.css b/src/main/java/com/google/gerrit/client/GerritCss.css
index edd5cfee3f..ddf2c9b727 100644
--- a/src/main/java/com/google/gerrit/client/GerritCss.css
+++ b/src/main/java/com/google/gerrit/client/GerritCss.css
@@ -525,6 +525,7 @@
}
.gerrit-ChangeInfoBlock {
+ margin-right: 15px;
}
.gerrit-InfoBlock {
diff --git a/src/main/java/com/google/gerrit/client/changes/ChangeDescriptionBlock.java b/src/main/java/com/google/gerrit/client/changes/ChangeDescriptionBlock.java
index eadb12fd1d..17dc4db0ad 100644
--- a/src/main/java/com/google/gerrit/client/changes/ChangeDescriptionBlock.java
+++ b/src/main/java/com/google/gerrit/client/changes/ChangeDescriptionBlock.java
@@ -21,7 +21,6 @@ import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.DisclosurePanel;
import com.google.gwt.user.client.ui.HTML;
import com.google.gwt.user.client.ui.HorizontalPanel;
-import com.google.gwt.user.client.ui.Label;
import com.google.gwtexpui.safehtml.client.SafeHtml;
import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
@@ -36,14 +35,10 @@ public class ChangeDescriptionBlock extends Composite {
description.setStyleName("gerrit-ChangeScreen-Description");
descriptionPanel = new DisclosurePanel(Util.C.changeScreenDescription());
{
- final Label glue = new Label();
final HorizontalPanel hp = new HorizontalPanel();
- hp.add(description);
- hp.add(glue);
hp.add(infoBlock);
- hp.setCellWidth(glue, "15px;");
+ hp.add(description);
descriptionPanel.setContent(hp);
- descriptionPanel.setWidth("100%");
}
initWidget(descriptionPanel);
}