Add some basic RefControl tests for delegated ownership

While trying to understand what was wrong in issue 672 I started
to write up some unit tests for RefControl.  These don't give us
a whole lot of code coverage here, but its a simple start that
we can build on later.

Change-Id: Ib216a3d911c8447004528074a000e9424bcd711d
Signed-off-by: Shawn O. Pearce <sop@google.com>

2 files changed, 223 insertions, 0 deletions

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java
index 00e92b6f58..330fc6efa8 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java
@@ -97,6 +97,10 @@ public class ProjectState {
     return inheritedRights;
   }
 
+  void setInheritedRights(Collection<RefRight> all) {
+    inheritedRights = all;
+  }
+
   private Collection<RefRight> computeInheritedRights() {
     if (isSpecialWildProject()) {
       return Collections.emptyList();
diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
new file mode 100644
index 0000000000..c789feae45
--- /dev/null
+++ b/gerrit-server/src/test/java/com/google/gerrit/server/project/RefControlTest.java
@@ -0,0 +1,219 @@
+// Copyright (C) 2010 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.gerrit.server.project;
+
+import static com.google.gerrit.reviewdb.ApprovalCategory.OWN;
+
+import com.google.gerrit.reviewdb.AccountGroup;
+import com.google.gerrit.reviewdb.AccountProjectWatch;
+import com.google.gerrit.reviewdb.ApprovalCategory;
+import com.google.gerrit.reviewdb.Change;
+import com.google.gerrit.reviewdb.Project;
+import com.google.gerrit.reviewdb.RefRight;
+import com.google.gerrit.reviewdb.SystemConfig;
+import com.google.gerrit.reviewdb.RefRight.RefPattern;
+import com.google.gerrit.server.AccessPath;
+import com.google.gerrit.server.AnonymousUser;
+import com.google.gerrit.server.CurrentUser;
+import com.google.gerrit.server.config.AuthConfig;
+import com.google.gerrit.server.config.GerritServerConfig;
+import com.google.inject.AbstractModule;
+import com.google.inject.Guice;
+import com.google.inject.Injector;
+
+import junit.framework.TestCase;
+
+import org.apache.commons.codec.binary.Base64;
+import org.eclipse.jgit.lib.Config;
+
+import java.io.UnsupportedEncodingException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+public class RefControlTest extends TestCase {
+  public void testOwnerProject() {
+    local.add(grant(OWN, admin, "refs/*", 1));
+
+    ProjectControl uBlah = user(devs);
+    ProjectControl uAdmin = user(devs, admin);
+
+    assertFalse("not owner", uBlah.isOwner());
+    assertTrue("is owner", uAdmin.isOwner());
+  }
+
+  public void testBranchDelegation1() {
+    local.add(grant(OWN, admin, "refs/*", 1));
+    local.add(grant(OWN, devs, "refs/heads/x/*", 1));
+
+    ProjectControl uDev = user(devs);
+    assertFalse("not owner", uDev.isOwner());
+    assertTrue("owns ref", uDev.isOwnerAnyRef());
+
+    assertOwner("refs/heads/x/*", uDev);
+    assertOwner("refs/heads/x/y", uDev);
+    assertOwner("refs/heads/x/y/*", uDev);
+
+    assertNotOwner("refs/*", uDev);
+    assertNotOwner("refs/heads/master", uDev);
+  }
+
+  public void testBranchDelegation2() {
+    local.add(grant(OWN, admin, "refs/*", 1));
+    local.add(grant(OWN, devs, "refs/heads/x/*", 1));
+    local.add(grant(OWN, fixers, "-refs/heads/x/y/*", 1));
+
+    ProjectControl uDev = user(devs);
+    assertFalse("not owner", uDev.isOwner());
+    assertTrue("owns ref", uDev.isOwnerAnyRef());
+
+    assertOwner("refs/heads/x/*", uDev);
+    assertOwner("refs/heads/x/y", uDev);
+    assertNotOwner("refs/*", uDev);
+    assertNotOwner("refs/heads/master", uDev);
+    assertNotOwner("refs/heads/x/y/*", uDev);
+
+    ProjectControl uFix = user(fixers);
+    assertFalse("not owner", uFix.isOwner());
+    assertTrue("owns ref", uFix.isOwnerAnyRef());
+
+    assertOwner("refs/heads/x/y/*", uFix);
+    assertOwner("refs/heads/x/y/bar", uFix);
+    assertNotOwner("refs/heads/x/*", uFix);
+    assertNotOwner("refs/heads/x/y", uFix);
+    assertNotOwner("refs/*", uFix);
+    assertNotOwner("refs/heads/master", uFix);
+  }
+
+
+  // -----------------------------------------------------------------------
+
+  private final Project.NameKey projectNameKey = new Project.NameKey("test");
+  private final AccountGroup.Id admin = new AccountGroup.Id(1);
+  private final AccountGroup.Id anonymous = new AccountGroup.Id(2);
+  private final AccountGroup.Id registered = new AccountGroup.Id(3);
+
+  private final AccountGroup.Id devs = new AccountGroup.Id(4);
+  private final AccountGroup.Id fixers = new AccountGroup.Id(5);
+
+  private final AuthConfig authConfig;
+  private final AnonymousUser anonymousUser;
+
+  public RefControlTest() {
+    final SystemConfig systemConfig = SystemConfig.create();
+    systemConfig.adminGroupId = admin;
+    systemConfig.anonymousGroupId = anonymous;
+    systemConfig.registeredGroupId = registered;
+    systemConfig.batchUsersGroupId = anonymous;
+    try {
+      byte[] bin = "abcdefghijklmnopqrstuvwxyz".getBytes("UTF-8");
+      systemConfig.registerEmailPrivateKey = Base64.encodeBase64String(bin);
+    } catch (UnsupportedEncodingException err) {
+      throw new RuntimeException("Cannot encode key", err);
+    }
+
+    Injector injector = Guice.createInjector(new AbstractModule() {
+      @Override
+      protected void configure() {
+        bind(Config.class) //
+            .annotatedWith(GerritServerConfig.class) //
+            .toInstance(new Config());
+
+        bind(SystemConfig.class).toInstance(systemConfig);
+        bind(AuthConfig.class);
+        bind(AnonymousUser.class);
+      }
+    });
+    authConfig = injector.getInstance(AuthConfig.class);
+    anonymousUser = injector.getInstance(AnonymousUser.class);
+  }
+
+  private List<RefRight> local;
+  private List<RefRight> inherited;
+
+  @Override
+  protected void setUp() throws Exception {
+    super.setUp();
+    local = new ArrayList<RefRight>();
+    inherited = new ArrayList<RefRight>();
+  }
+
+  private static void assertOwner(String ref, ProjectControl u) {
+    assertTrue("OWN " + ref, u.controlForRef(ref).isOwner());
+  }
+
+  private static void assertNotOwner(String ref, ProjectControl u) {
+    assertFalse("NOT OWN " + ref, u.controlForRef(ref).isOwner());
+  }
+
+  private RefRight grant(ApprovalCategory.Id categoryId, AccountGroup.Id group,
+      String ref, int maxValue) {
+    return grant(categoryId, group, ref, maxValue, maxValue);
+  }
+
+  private RefRight grant(ApprovalCategory.Id categoryId, AccountGroup.Id group,
+      String ref, int minValue, int maxValue) {
+    RefRight right =
+        new RefRight(new RefRight.Key(projectNameKey, new RefPattern(ref),
+            categoryId, group));
+    right.setMinValue((short) minValue);
+    right.setMaxValue((short) maxValue);
+    return right;
+  }
+
+  private ProjectControl user(AccountGroup.Id... memberOf) {
+    return new ProjectControl(new MockUser(memberOf), newProjectState());
+  }
+
+  private ProjectState newProjectState() {
+    ProjectCache projectCache = null;
+    Project.NameKey wildProject = null;
+    ProjectState ps =
+        new ProjectState(anonymousUser, projectCache, wildProject, new Project(
+            projectNameKey), local);
+    ps.setInheritedRights(inherited);
+    return ps;
+  }
+
+  private class MockUser extends CurrentUser {
+    private final Set<AccountGroup.Id> groups;
+
+    MockUser(AccountGroup.Id[] groupId) {
+      super(AccessPath.UNKNOWN, RefControlTest.this.authConfig);
+      groups = new HashSet<AccountGroup.Id>(Arrays.asList(groupId));
+      groups.add(registered);
+      groups.add(anonymous);
+    }
+
+    @Override
+    public Set<AccountGroup.Id> getEffectiveGroups() {
+      return groups;
+    }
+
+    @Override
+    public Set<Change.Id> getStarredChanges() {
+      return Collections.emptySet();
+    }
+
+    @Override
+    public Collection<AccountProjectWatch> getNotificationFilters() {
+      return Collections.emptySet();
+    }
+  }
+}