summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShawn O. Pearce <sop@google.com>2011-05-20 07:17:03 -0700
committerShawn O. Pearce <sop@google.com>2011-05-20 07:17:03 -0700
commit79a9896f599eede025e0ad78d11c8cf24dade896 (patch)
treecc2cdaec130da6588dc9b3ac3c725a37848813fb
parent70d336d49b02b5db7b24bb91beddcf4d4a02dbd9 (diff)
Send new patchset event after its available
gerrit stream-events sent notification of a new patch set before it created the reference in the Git repository. This confused some CI systems that were able to read the stream-events message and look for the reference before the server was able to create it. Bug: issue 755 Change-Id: I14eb9d19984701eb9afbb13e006a24057e8c3473 Signed-off-by: Shawn O. Pearce <sop@google.com>
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java3
1 files changed, 1 insertions, 2 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
index 445974fe7b..4380ff015f 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
@@ -1373,8 +1373,6 @@ public class ReceiveCommits implements PreReceiveHook, PostReceiveHook {
insertDummyApproval(result, reviewer, catId, db);
}
}
-
- hooks.doPatchsetCreatedHook(result.change, ps);
}
final RefUpdate ru = repo.updateRef(ps.getRefName());
@@ -1385,6 +1383,7 @@ public class ReceiveCommits implements PreReceiveHook, PostReceiveHook {
+ repo.getDirectory() + ": " + ru.getResult());
}
replication.scheduleUpdate(project.getNameKey(), ru.getName());
+ hooks.doPatchsetCreatedHook(result.change, ps);
request.cmd.setResult(ReceiveCommand.Result.OK);
try {