diff options
author | Edwin Kempin <edwin.kempin@sap.com> | 2011-05-19 18:59:55 +0200 |
---|---|---|
committer | Edwin Kempin <edwin.kempin@sap.com> | 2011-05-19 18:59:55 +0200 |
commit | abb9159382db988a393e4bc9d19f4b92a0e8fc89 (patch) | |
tree | 3042821f7a73e42ea3847011fe51fae7d969e2be | |
parent | 767ded566dc731018c712830fe6b1b7183a237b1 (diff) |
Go back to change screen if 'Publish and Submit' fails on submit
The 'Publish and Submit' action is not atomic. This means if the
submit fails the comments and approvals will still be published.
If the screen stays with the PublishCommentScreen on submit failure
there is no indication for the user that the comments and approvals
were actually published. To make this more obvious we now go back to
the change screen before displaying the submit error. On the change
screen the user can then see that the comments and approvals were
successfully published.
Bug: issue 963
Change-Id: I9fcfd6b89b53db6f672d79714c6942fa953e5dd9
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
-rw-r--r-- | gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java index d94433acff..0ed58b41d0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PublishCommentScreen.java @@ -370,8 +370,8 @@ public class PublishCommentScreen extends AccountScreen implements @Override public void onFailure(Throwable caught) { + goChange(); super.onFailure(caught); - enableForm(true); } }); } |