diff options
| author | Dave Borowitz <dborowitz@google.com> | 2015-05-07 11:26:09 -0700 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2015-05-12 10:35:50 +0900 |
| commit | 92c3fd88aaba6851e4599083cb1b1a9c634cbbe9 (patch) | |
| tree | 6277369a4451a69eaa6dfde8ee1c00a92dd4ec4b | |
| parent | a031b8063ecd03f10f8b40b84ca7deb41de1d8a8 (diff) | |
ChangeJson: Less eager loading of patch sets
Normal search results do not include the MESSAGES or any REVISION
options, so they should not need to load the current revision from the
PatchSets table (assuming mergeability cache hits). This was just
wasted DB access, accounting for up to 20% of query traffic.
Change-Id: I641d4af1a71391bcd18ded838224d7a3ee3f57d7
| -rw-r--r-- | gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index 240c9a0305..181742f5b4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java @@ -264,7 +264,7 @@ public class ChangeJson { ChangeData.ensureChangeLoaded(all); if (has(ALL_REVISIONS)) { ChangeData.ensureAllPatchSetsLoaded(all); - } else { + } else if (has(CURRENT_REVISION) || has(MESSAGES)) { ChangeData.ensureCurrentPatchSetLoaded(all); } Set<Change.Id> reviewed = Sets.newHashSet(); |