summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugo Arès <hugo.ares@ericsson.com>2016-02-09 14:02:16 -0500
committerDavid Pursehouse <david.pursehouse@sonymobile.com>2016-02-10 10:02:55 +0900
commit61af5c11d8a611745ff8094e64070f8568c69c70 (patch)
tree9134a957d93099493959a3f8b947e03626369deb
parent014f1e4e16fc25c4d03d75ccf22621116c42ff68 (diff)
OutputStreamQuery: fix comments with current-patch-set option
Comments were added at the change level but were not added at the patch set level when using with current-patch-set option. Change-Id: I85336d67ad9aafe972ecfd86f95175093d4449cd
-rw-r--r--gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/QueryIT.java25
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java4
2 files changed, 29 insertions, 0 deletions
diff --git a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/QueryIT.java b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/QueryIT.java
index a7e001b516..066d3628d7 100644
--- a/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/QueryIT.java
+++ b/gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/QueryIT.java
@@ -197,6 +197,31 @@ public class QueryIT extends AbstractDaemonTest {
}
@Test
+ public void testCommentOptionsInCurrentPatchSetJSON() throws Exception {
+ String changeId = createChange().getChangeId();
+
+ ReviewInput review = new ReviewInput();
+ ReviewInput.CommentInput comment = new ReviewInput.CommentInput();
+ comment.path = PushOneCommit.FILE_NAME;
+ comment.side = Side.REVISION;
+ comment.message = "comment 1";
+ review.comments = new HashMap<>();
+ review.comments.put(comment.path, Lists.newArrayList(comment));
+ gApi.changes().id(changeId).current().review(review);
+
+ List<ChangeAttribute> changes =
+ executeSuccessfulQuery("--current-patch-set " + changeId);
+ assertThat(changes.size()).isEqualTo(1);
+ assertThat(changes.get(0).currentPatchSet.comments).isNull();
+
+ changes =
+ executeSuccessfulQuery("--current-patch-set --comments " + changeId);
+ assertThat(changes.size()).isEqualTo(1);
+ assertThat(changes.get(0).currentPatchSet.comments).isNotNull();
+ assertThat(changes.get(0).currentPatchSet.comments.size()).isEqualTo(1);
+ }
+
+ @Test
public void testCommentOptionInPatchSetsJSON() throws Exception {
String changeId = createChange().getChangeId();
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java
index 1825b91560..d594f8acdf 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/OutputStreamQuery.java
@@ -230,6 +230,10 @@ public class OutputStreamQuery {
eventFactory.addPatchSetFileNames(c.currentPatchSet,
d.change(), d.currentPatchSet());
}
+ if (includeComments) {
+ eventFactory.addPatchSetComments(c.currentPatchSet,
+ d.publishedComments());
+ }
}
}