RegisterNewEmailSender: Don't unconditionally send verification mail

If the server configuration includes sendemail.allowrcpt, and the
user attempts to register an email address that is not included in
the allowed list, OutgoingEmail will skip adding that address to the
list of recipients.  However, RegisterNewEmailSender overrides the
'shouldSendMessage' method to always return true, which means Gerrit
still attempts to send the verification mail which has no recipients.

This results in an error from the SMTP server:

   rejected DATA command: 503 5.5.2 Need rcpt command

which in turn results in an "Internal server error" message to the
user.

Remove the overridden shouldSendMessage method, so that the default
implementation (which checks for recipients and content) is used.

Change-Id: I4f756f98627447a3f23ecdc9fa82309ba0a0271a

1 files changed, 0 insertions, 5 deletions

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RegisterNewEmailSender.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RegisterNewEmailSender.java
index eb32700c50..c24997bc70 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/RegisterNewEmailSender.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/RegisterNewEmailSender.java
@@ -48,11 +48,6 @@ public class RegisterNewEmailSender extends OutgoingEmail {
   }
 
   @Override
-  protected boolean shouldSendMessage() {
-    return true;
-  }
-
-  @Override
   protected void format() throws EmailException {
     appendText(velocifyFile("RegisterNewEmail.vm"));
   }