summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSaša Živkov <sasa.zivkov@sap.com>2016-10-28 17:43:10 +0200
committerSaša Živkov <sasa.zivkov@sap.com>2016-10-28 17:46:12 +0200
commit4d07688b1e30ec1fad1def21fd5eac788ea19438 (patch)
tree3bac098beb3319091934ddf7cfb26d54966a146d
parent77464107c450d6bdd5d98103f6e4caa65441972b (diff)
Fix Schema_127 for mysql on case-sensitive FS
mysql tables are case-sensitive when mysql runs on a case-sensitive file system (like linux). Schema_127 failed when upgrading Gerrit using mysql on linux because it couldn't find the ACCOUNT_PATCH_REVIEWS table in mysql. Use lowercase for the table name and also for column names. This is also compatible with the code in other Schema* classes. Change-Id: I13ba89a25c87790e74c43221c6573812876b1f70
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_127.java14
1 files changed, 7 insertions, 7 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_127.java b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_127.java
index b9e4bfa19f..783cce6603 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_127.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_127.java
@@ -45,18 +45,18 @@ public class Schema_127 extends SchemaVersion {
H2AccountPatchReviewStore.createTableIfNotExists(url);
try (Connection con = DriverManager.getConnection(url);
PreparedStatement stmt =
- con.prepareStatement("INSERT INTO ACCOUNT_PATCH_REVIEWS "
- + "(ACCOUNT_ID, CHANGE_ID, PATCH_SET_ID, FILE_NAME) VALUES "
+ con.prepareStatement("INSERT INTO account_patch_reviews "
+ + "(account_id, change_id, patch_set_id, file_name) VALUES "
+ "(?, ?, ?, ?)")) {
int batchCount = 0;
try (Statement s = newStatement(db);
- ResultSet rs = s.executeQuery("SELECT * from ACCOUNT_PATCH_REVIEWS")) {
+ ResultSet rs = s.executeQuery("SELECT * from account_patch_reviews")) {
while (rs.next()) {
- stmt.setInt(1, rs.getInt("ACCOUNT_ID"));
- stmt.setInt(2, rs.getInt("CHANGE_ID"));
- stmt.setInt(3, rs.getInt("PATCH_SET_ID"));
- stmt.setString(4, rs.getString("FILE_NAME"));
+ stmt.setInt(1, rs.getInt("account_id"));
+ stmt.setInt(2, rs.getInt("change_id"));
+ stmt.setInt(3, rs.getInt("patch_set_id"));
+ stmt.setString(4, rs.getString("file_name"));
stmt.addBatch();
batchCount++;
if (batchCount >= MAX_BATCH_SIZE) {