diff options
| author | David Ostrovsky <david@ostrovsky.org> | 2017-04-05 09:07:31 +0200 |
|---|---|---|
| committer | David Pursehouse <dpursehouse@collab.net> | 2017-04-06 08:10:26 +0000 |
| commit | fc555d785458a22a9d29bc089d14cca409640e36 (patch) | |
| tree | e62a235931444ee1431bc53e169f9126cf0e1fa7 | |
| parent | cdeb08b3ea8dbb027f1fff617f5921321be5a339 (diff) | |
Gerrit#updateUiLink: Fix access to undefined property
uiSwitcherLink attribute is instantiated conditionally, when PG UI was
not disabled. The invocation of setHref() method on it:
uiSwitcherLink.setHref(getUiSwitcherUrl(token));
was done unconditionally. That leads to this error:
(TypeError) : Cannot read property 'setHref' of undefined
Bug: Issue 5929
Change-Id: I872cdf7d41ab36e03126df54bb12c9071da5543d
| -rw-r--r-- | gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java index 17ad4f6c05..751302ebee 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java @@ -598,7 +598,9 @@ public class Gerrit implements EntryPoint { } private static void updateUiLink(String token) { - uiSwitcherLink.setHref(getUiSwitcherUrl(token)); + if (uiSwitcherLink != null) { + uiSwitcherLink.setHref(getUiSwitcherUrl(token)); + } } private void onModuleLoad2(HostPageData hpd) { |