summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiri Danek <jdanek@redhat.com>2018-07-12 09:14:16 +0200
committerDavid Pursehouse <dpursehouse@collab.net>2018-07-12 17:39:50 +0900
commit5b3d230a79dc5168740c338e67c49c6412af82e5 (patch)
tree764ea786b2512d74d4de6061c838be8702d7d30a
parentc3d8c937dd4916dcaa34c54157e15ecf17922058 (diff)
Fix call to the fail skylark global in junit.bzl
The fail function takes an already formatted message, it does not provide for formatting arguments, the way Python's logger.log does, for example. I did not find any other improperly made call to fail in the rest of the bazlets project. C.f. https://docs.bazel.build/versions/master/skylark/lib/globals.html#fail Change-Id: If187b4d1f97ef331ead8a34f499c97cd8d5728f9
-rw-r--r--tools/bzl/junit.bzl6
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/bzl/junit.bzl b/tools/bzl/junit.bzl
index d4e0606e63..ba3b966ed9 100644
--- a/tools/bzl/junit.bzl
+++ b/tools/bzl/junit.bzl
@@ -43,11 +43,7 @@ def _AsClassName(fname):
if findex != -1:
break
if findex == -1:
- fail(
- "%s does not contain any of %s",
- fname,
- _PREFIXES,
- )
+ fail("%s does not contain any of %s" % (fname, _PREFIXES))
return ".".join(toks[findex:]) + ".class"
def _impl(ctx):