diff options
| author | David Pursehouse <dpursehouse@collab.net> | 2018-09-03 11:04:14 +0900 |
|---|---|---|
| committer | David Pursehouse <dpursehouse@collab.net> | 2018-09-03 11:10:29 +0900 |
| commit | 8f4d9b58c602c506f7dca55e2a2361f0b170b890 (patch) | |
| tree | ed8c1d06919d781bb9547d70731c86ba3474cd86 | |
| parent | 8c9f93493a68652fd2f6e56b345347d3a1206f11 (diff) | |
ConfigSuite: Instantiate class via getDeclaredConstructor()
ErrorProne reports a warning [1] about bypassing exception checking
by instantiation with direct call to #newInstance. It also mentions
that #newInstance is to be deprecated from Java 9.
[1] http://errorprone.info/bugpattern/ClassNewInstance
Change-Id: Id20631933bce8ab320dd5e321336bad9e181cfa0
| -rw-r--r-- | gerrit-server/src/test/java/com/google/gerrit/testutil/ConfigSuite.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gerrit-server/src/test/java/com/google/gerrit/testutil/ConfigSuite.java b/gerrit-server/src/test/java/com/google/gerrit/testutil/ConfigSuite.java index c29b06e895..8d6036a0b1 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/testutil/ConfigSuite.java +++ b/gerrit-server/src/test/java/com/google/gerrit/testutil/ConfigSuite.java @@ -120,7 +120,7 @@ public class ConfigSuite extends Suite { @Override public Object createTest() throws Exception { - Object test = getTestClass().getJavaClass().newInstance(); + Object test = getTestClass().getJavaClass().getDeclaredConstructor().newInstance(); parameterField.set(test, callConfigMethod(configMethod)); if (nameField != null) { nameField.set(test, name); |