summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Pursehouse <dpursehouse@collab.net>2019-02-04 08:52:57 +0900
committerDavid Pursehouse <dpursehouse@collab.net>2019-02-04 08:53:54 +0900
commitb73cb380c4ac4a5e6e151e69a05c45b32269940f (patch)
tree56c55ccc1e9f28dfea318a76147c7c5a17d46c86
parent2109f3c35a247d41fea5af8cee5382476837082b (diff)
CommitValidators: Replace indexOf calls with String#contains
Partial cherry-pick of commit 249d47b done in order to make subsequent cherry-picks cleaner. Change-Id: I7288a18d38351ebe87aa8fc25b2c232310b1273f
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
index 0eb781939e..6724ddeab6 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
@@ -290,9 +290,9 @@ public class CommitValidators {
StringBuilder sb = new StringBuilder();
sb.append("ERROR: ").append(errMsg);
- if (c.getFullMessage().indexOf(CHANGE_ID_PREFIX) >= 0) {
+ if (c.getFullMessage().contains(CHANGE_ID_PREFIX)) {
String lastLine = Iterables.getLast(Splitter.on('\n').split(c.getFullMessage()), "");
- if (lastLine.indexOf(CHANGE_ID_PREFIX) == -1) {
+ if (!lastLine.contains(CHANGE_ID_PREFIX)) {
sb.append('\n');
sb.append('\n');
sb.append("Hint: A potential ");