diff options
author | David Pursehouse <dpursehouse@collab.net> | 2019-02-18 23:22:59 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-02-18 23:22:59 +0000 |
commit | 52ee3af5b560c337247971ac9c2cb5f042cfd45a (patch) | |
tree | b4b31c05087c35b5def1f4910b8d6857b07bee9d | |
parent | 998cbc1fa46b45c07661adf25bc9f978ad74f890 (diff) | |
parent | 793eb81ec55eb418e9b14c77a62901f09ff55595 (diff) |
Merge "ElasticContainer: Bump V7_0 test server to 7.0.0-beta1" into stable-2.15
3 files changed, 10 insertions, 2 deletions
diff --git a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java index c21299f7fd..4f811b9ee6 100644 --- a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java +++ b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java @@ -163,7 +163,9 @@ abstract class AbstractElasticIndex<K, V> implements Index<K, V> { // Recreate the index. String indexCreationFields = concatJsonString(getSettings(), getMappings()); - response = performRequest("PUT", indexName, indexCreationFields); + response = + performRequest( + "PUT", indexName + client.adapter().includeTypeNameParam(), indexCreationFields); statusCode = response.getStatusLine().getStatusCode(); if (statusCode != HttpStatus.SC_OK) { String error = String.format("Failed to create index %s: %s", indexName, statusCode); diff --git a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java index 0c28dd1c62..85fbee8556 100644 --- a/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java +++ b/gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java @@ -29,6 +29,7 @@ public class ElasticQueryAdapter { private final String stringFieldType; private final String indexProperty; private final String versionDiscoveryUrl; + private final String includeTypeNameParam; ElasticQueryAdapter(ElasticVersion version) { this.ignoreUnmapped = false; @@ -40,6 +41,7 @@ public class ElasticQueryAdapter { this.exactFieldType = "keyword"; this.stringFieldType = "text"; this.indexProperty = "true"; + this.includeTypeNameParam = version.isV7OrLater() ? "?include_type_name=true" : ""; } void setIgnoreUnmapped(JsonObject properties) { @@ -89,4 +91,8 @@ public class ElasticQueryAdapter { String getVersionDiscoveryUrl(String name) { return String.format(versionDiscoveryUrl, name); } + + String includeTypeNameParam() { + return includeTypeNameParam; + } } diff --git a/gerrit-elasticsearch/src/test/java/com/google/gerrit/elasticsearch/ElasticContainer.java b/gerrit-elasticsearch/src/test/java/com/google/gerrit/elasticsearch/ElasticContainer.java index 3687aa937f..454bffd363 100644 --- a/gerrit-elasticsearch/src/test/java/com/google/gerrit/elasticsearch/ElasticContainer.java +++ b/gerrit-elasticsearch/src/test/java/com/google/gerrit/elasticsearch/ElasticContainer.java @@ -49,7 +49,7 @@ public class ElasticContainer extends ElasticsearchContainer { case V6_6: return "docker.elastic.co/elasticsearch/elasticsearch-oss:6.6.0"; case V7_0: - return "docker.elastic.co/elasticsearch/elasticsearch-oss:7.0.0-alpha2"; + return "docker.elastic.co/elasticsearch/elasticsearch-oss:7.0.0-beta1"; } throw new IllegalStateException("No tests for version: " + version.name()); } |